Comments (7)
No worries, it's a messy issue and one I've been dealing with in our own apps all week. I'm glad you found your culprit! I'm going to close this, but feel free to re-open if it turns out there is something we need to do here.
from ember-fontawesome.
That issue lies with any addon that has a pre 0.50 version of @embroider/macros
. Many addons will need to be updated to @embroider/macros@v1
. In our case that dependency comes from using ember-get-config
. The best place to look for the issue is to run npm ls @embroider/macros
and see what addons you have that need to be updated. I don't think there is anything that needs to be done here, but PRs welcome if I'm wrong. You're seeing this error in your app after the release here because of our dependency on ember-get-config
.
from ember-fontawesome.
Thank you very much and sorry for opening an issue that was not related to FortAwesome (I suspected that but the issue arose after updating just it). I hope this could be helpful to identify the scenario for others.
In my case the culprit is ember-power-select
from ember-fontawesome.
I've stumbled upon the same issue. Thank you @jrjohnson for describing details of the issue and providing npm ls
command (TIL!) for tracking dependencies.
In my case the problem is caused by 2 addons:
[email protected]
relies on@embroider/[email protected]
(via[email protected]
)[email protected]
relies on@embroider/[email protected]
from ember-fontawesome.
fwiw, this addon could easily do without ember-get-config
. It's only used in a component file, meaning you could just resolve the config instead. v1 of ember-get-config
works significantly different than older versions and not really in a good way. It includes your config multiple times in the final build and the config you get from ember-get-config
is not necessarily the same as the config an app author gets when doing import config from 'app/config/environment'
.
Personally I would ditch ember-get-config
here.
from ember-fontawesome.
@bertdeblock PR welcome! However getting the config from and add-on that may be consumed by other addons isn't as simple as importing it. That's the main advantage of ember-get-config
, it handles the tricky part.
from ember-fontawesome.
getting the config from and add-on that may be consumed by other addons
I don't think the nesting of your addon matters if you do owner.resolveRegistration('config:environment')
.
I think that should always return the app's config.
Anyhow, ember-get-config
v2 was just released.
At first glance, it seems to address the issues mentioned above.
EDIT: afaict, v2 still has (some of) the same issues.
from ember-fontawesome.
Related Issues (20)
- Helper as delivery mechanism
- Error when rendering icon after using the "Translate to <spoken language>" feature in Google Chrome
- getWithDefault depreciation HOT 2
- `htmlSafe` From `@ember/string` Is Deprecated HOT 3
- Passing `@click` is discouraged by linting HOT 2
- FontAwesome 6 Support HOT 17
- How to use symbols?
- DEPRECATION: Use of `assign` has been deprecated. Please use `Object.assign` or the spread operator instead. HOT 5
- Kit support
- Icon sizes changed after upgrading HOT 6
- Ember build error after installing ember-fontawesome HOT 5
- Build error when including `stopwatch-20` icon
- Build fails after install HOT 1
- WARNING: 0.3.3 contains updates to font-awesome 5.x to 6.x not listed in the 0.3.3 notes HOT 3
- Absolute path to package is presented in the build output assets HOT 2
- chunk.*.js contains all icons even though config/icons.js is present HOT 5
- Add support for new Sharp styles HOT 1
- v1.0.0: 'faCheck' is not exported by node_modules/@fortawesome/free-solid-svg-icons/index.js HOT 14
- Error: "Insufficient rollup version" when updating to latest version HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-fontawesome.