Giter Club home page Giter Club logo

Comments (5)

mbrookes avatar mbrookes commented on August 20, 2024

Version bumped in packages.json, README updated, published to npm. I didn't force reset the tag with these changes.

from formsy-material-ui.

vijayrawatsan avatar vijayrawatsan commented on August 20, 2024

@mbrookes I did a mistake in v0.2.3. I have fixed that mistake and applied this approach
https://github.com/christianalfoni/formsy-react/wiki/validate-on-blur
in following pr. Please have a look and let me know if I can merge.
#12

Thanks

from formsy-material-ui.

mbrookes avatar mbrookes commented on August 20, 2024

@vijayrawatsan Can you briefly explain what broke, and how this fixes it? Thanks.

from formsy-material-ui.

vijayrawatsan avatar vijayrawatsan commented on August 20, 2024

What broke?
Basically my previous commit added value={this.getValue() to FormsyText which was earlier ommited and looked the right thing to do(christianalfoni/formsy-react#117).
Issue was there due to onBlur,
formsy-material-ui FormsyText uses onBlur instead of onChange. Due to this after the first onBlur on any inputtext I was not able to change the value of that text field as next value change will happen on onBlur but value is referring to this.getValue()

I tried to be as clear as possible do let me know if you did not understand.

In my new pull request I used this approach to validate FormsyText
https://github.com/christianalfoni/formsy-react/wiki/validate-on-blur
which is the best possible way till now to validate and looks natural.

from formsy-material-ui.

mbrookes avatar mbrookes commented on August 20, 2024

Closing this since npm is updated (albeit with a broken version). FWIW it originally had value={this.getValue(0} when validation was onChange, but it subsequently appeared redundant. Clearly that wasn't the case! :)

We can move the discussion to the relevant PR.

from formsy-material-ui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.