Giter Club home page Giter Club logo

Comments (5)

LeMamin avatar LeMamin commented on August 15, 2024 1

@abdallamohamed Since version 2.0.0 $translate('key') returns an promise!

You can use return $translate.instant(text) to getting the translation right away without waiting for a promise (use the service in sync). Can you do a pull request?
https://angular-translate.github.io/docs/#/guide/21_migration-guide

Thanks

from ngformio.

LeMamin avatar LeMamin commented on August 15, 2024

@abdallamohamed
The problem is in the src/filters/translate.js : return $translate(text) (promise)

The translate filter doesn't work: {{ "Day" | formioTranslate:null:builder }}

from ngformio.

AbdallaElabd avatar AbdallaElabd commented on August 15, 2024

@LeMamin Do you suggest using the $filter service instead of $translate? https://angular-translate.github.io/docs/#/api/pascalprecht.translate.filter:translate

It'd still be ambiguous because other libraries use the same filter name. Is there a way of getting the translation right away without waiting for a promise to be resolved?

from ngformio.

AbdallaElabd avatar AbdallaElabd commented on August 15, 2024

@LeMamin Thanks for committing that. Will you make a PR for it and include the maintainers from formio?

from ngformio.

LeMamin avatar LeMamin commented on August 15, 2024

@abdallamohamed the PR was merge : PR #331

from ngformio.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.