Giter Club home page Giter Club logo

Comments (5)

Ephem avatar Ephem commented on May 26, 2024 1

Nice catch! I’m pretty sure though that React itself gives no guarantees these will only be called once across suspends. See for example this issue.

from react-ssr-prepass.

bmathews avatar bmathews commented on May 26, 2024

Thanks @Ephem ! While that behavior is unfortunate, it sounds like it's the 'correct' behavior at the moment.

from react-ssr-prepass.

Ephem avatar Ephem commented on May 26, 2024

Yeah, it confused me at first too. 😀 It’s equally correct to memoize across suspends of course, so it’s definitely possible to implement this as an optimization!

from react-ssr-prepass.

achung89 avatar achung89 commented on May 26, 2024

This'd be nice, as it would allow executing and caching suspense promises on mount

from react-ssr-prepass.

kitten avatar kitten commented on May 26, 2024

@achung89 You should avoid caching suspense promises or other “global loading state” in a single component’s state. This may cause subtle bugs that are then hard to iron out. Chances are you may want to have a shared cache across context if you’re doing this, but of course, libraries exist to make it easier to handle fetching logic, although some don’t play nicely with suspense.

If you really need state across suspenses in react-ssr-prepass then maybe try using a ref. It’s worth noting though that React itself doesn’t usually preserve any state across suspense.

from react-ssr-prepass.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.