Giter Club home page Giter Club logo

Comments (1)

kitten avatar kitten commented on May 23, 2024

I'm not quite sure I'm following this but basically, if I get this right:

  1. You've got an asynchronous fetchData on a component that is visited
  2. Then fetchData makes a query and you process the response and store it in some request-global / app-global state
  3. You then (in the affected case) perform a redirect, presumably still on the server
  4. The redirect isn't being made
  5. Some kind of second query comes into play

So I'm pretty sure for the last two points I'm missing some information to be able to help you. I assume you want to abort traversal at that point? So, that's obviously something that the react-ssr-prepass visitor doesn't support, so let's assume traversal continues.

After react-ssr-prepass is done you've marked request to redirect, but are you aborting all other actions, like server-side rendering?

Usually I'd do that (in my case an express server for instance) by checking whether a redirect was scheduled using req.headersSent. If you're not familiar with that, if you start a redirect then it's clear that your request doesn't need any other content in the response headers than the redirect, so Express goes ahead and sends the redirect down.

So at that point you can back off in your server-side code and say:

if (req.headersSent) return
// ... some React SSR code comes after

Now, I'm not sure what you mean by this last part:

second query doesn't provided to initial state and page looks incorrect

But could it be that you were relying on react-tree-walker's traversal cancellation, where you could stop it from traversing deeper by returning false?

There's a little "hack" that you can do, since you're not using suspense. You can take instance (the one you call instance.fetchData on) and change the state to tell you to abort early, e.g.:

class YourComponent extends React.Component {
  fetchData = async () => {
    await yourFetchCall()
    if (...) {
      res.redirect(...) // I assume this comes from somewhere
      this.setState({ abort: true })
    }
  }

  render() {
    if (this.state.abort) {
      return null; // stop traversal for react-ssr-prepass
    }

    // ...
  }
}

from react-ssr-prepass.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.