Giter Club home page Giter Club logo

Comments (4)

caridy avatar caridy commented on May 6, 2024

@gpbl I think you're in the right track, let me give you few more hints:

pass messages in one go

I will not recommend to organize your translations per react component, this is proven to be a refactor hazard. keep in mind that translations are normally re-use after a refactor, plus, professional translators should not be exposed to the implementation details and component organization, we recommend to organize them in logical groups that can tell translators where to look.

whatever organization you use for your translations (even if you decide to go with a very granular or a giant flat file with all translations), you should be able to pipe that thru the entire app:

render: function () {
    <MyApp messages={computedMessagesPerLocale[currentLocale]} locales={[currentLocale, fallbackLocale]}></App>
}

on the server

you can simply have a middleware to compute the currentLocale, and to require all language files (organized) in namespace if needed, and this is a one time operation per locale, not a big deal, essentially, based on the previous example, computedMessagesPerLocale should hold that information, including any fallback mechanism (computing missing entries, etc).

on the client

load a bundle with all locale (this is equivalent to computedMessagesPerLocale[currentLocale] and in fact can be computed once for server and client), then just pass that data into the app initialization. we do not recommend to have fallback for messages because that means you have to load 2 or more bundles, instead, rely on a build process to solve inconsistencies between language files, and apply completion on those that are missing or incomplete.

from formatjs.

gpbl avatar gpbl commented on May 6, 2024

Thanks @caridy for sharing your experience, you are right on everything :-) (I'm also against the fallbacks) I'll follow you ideas and keep this issue updated with my progress, in case someone else is interested.

from formatjs.

gpbl avatar gpbl commented on May 6, 2024

So after working for a while with react-intl, this isn't actually an issue anymore. A related discussion is #89.

from formatjs.

hjylewis avatar hjylewis commented on May 6, 2024

Hi all! ✌️

I was running into a similar issue and came up with a solution that inlines your localized messages so that it's coupled with your code and easy to split into smaller bundles (think CSS-in-JS for i18n messages). See this for more info on the motivation for it.

Check it out here: babel-plugin-inline-i18n-messages

This idea would it would inline the messages like this:

<FormattedMessage id="key.path.hello" />
<FormattedMessage id="key.path.sup" />

           

import { addMessages } from "i18n/addMessages.js";
addMessages([
  ["key.path.hello", "hello, world"],
  ["key.path.sup", "sup, world"],
]);
<FormattedMessage id="key.path.hello" />
<FormattedMessage id="key.path.sup" />

It plays very nicely with react-intl. Here's an example

I'd appreciate you all checking it out and letting me know if it solves your splitting issues 🙇

cc @gpbl @caridy

from formatjs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.