Giter Club home page Giter Club logo

Comments (2)

foonathan avatar foonathan commented on June 11, 2024
  1. The constructor of the tag is passed an iterator from which a location can be computed. My current workaround is to store the iterator in a std::any and do the mapping later. However, I am not a fan of using this type. I add a patch with a proposal to pass the state to the tag constructor, below.

That seems like a sensible addition. If you want, you can turn the patch into a PR, by also adding a test and documentation. (And incorporate the fix for 2.)

  1. Somehow the iterator passed to the tag is off by one. See the example below reproducing the issue.

Fixed.

  1. I don't like to use lexy::bind and rather use lexy::callback with lambdas. Would it be possible to have a convenience version that also receives the parse state?

I have added lexy::callback_with_state for that purpose.

from lexy.

rkaminsk avatar rkaminsk commented on June 11, 2024

Thanks, for the two additions! I'll open a PR, too. It can take 2 to 3 weeks though.

from lexy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.