Comments (12)
Donno. Any suggestions?
from region-flags.
Including region-flags as a submodule still doesn't work on Windows because its png folder has symlinks (BL.png, BQ.png, BV.png, CP.png, DG.png, EA.png, HM.png, MF.png, SJ.png, TF.png, UM.png) which generates Warning: Command failed: identify.exe: improper image header 'region-flags/png/BL.png' @ error/png.c/ReadPNGImage/3921.
. Copying the target country's file over the link gets past that error, but then the identify command (identify -verbose src/img/flags/@2x/*.png
with ImageMagick 6.9.2-0 Q16 x64 2015-08-15) exits with 1...which is odd because the same command exits 0 when invoked directly. Building the images isn't a concern for me right now, but FYI.
from region-flags.
I need suggestions as to how to proceed. @shervinafshar, can you think of any?
from region-flags.
Can't you just duplicate the files instead of symlinking them?
from region-flags.
We definitely can. Does "ln" fail in such situations? We can try this patch:
diff --git a/make-aliases.sh b/make-aliases.sh
index dab602a..d800c1f 100755
--- a/make-aliases.sh
+++ b/make-aliases.sh
@@ -11,7 +11,7 @@ while read from to; do
echo "ERROR: $f exist; skipping"
continue
fi
- ln -s "$to.$dir" "$f"
+ ln -s "$to.$dir" "$f" || cp "$dir/$to.$dir" "$f"
done
done < data/ALIASES
does that work for you?
from region-flags.
No it's the symlinks that already exist in the generated files e.g. png/BL.png
from region-flags.
Amazing thank you! Would you consider doing a release? Makes it easier to pull into other projects.
from region-flags.
Make a 1.0 tag / release.
from region-flags.
Thank you! Unfortunately I've just noticed the new commit is in the gh-pages branch instead of master!
from region-flags.
I have had intended to delete the master branch before. Done now. We only have a gh-pages branch now.
from region-flags.
Ok thanks! One last thing: for this to work with Bower, you need to use Semantic Versioning, which means the release tag needs to be called 1.0.0 - is that possible?
from region-flags.
Ugh. Done.
from region-flags.
Related Issues (20)
- Add optimized SVG using svgo HOT 2
- Add UN flag as well as rainbow flag? HOT 1
- Karnataka-India flag HOT 2
- Streamline svg icons / Some svg flag icons are broken HOT 4
- Use sub-directories for sub-regions
- ISO 3166-3 alpha-4 codes HOT 1
- WIPO ST.3 codes HOT 2
- Private-use codes Q…, X… HOT 1
- Add flag of District of Columbia HOT 2
- Add flags of Canadian provinces and territories HOT 2
- Any way to convert the SVG files of the flags for Android, to VectorDrawable files? HOT 4
- Afghan and Mauritanian flags out-of-date
- Overview of missing regions, states, territories, provinces and muncipalities (AR, AU, BQ, ES, FR, GE, NL, PT) HOT 3
- Only few reserved country codes missing
- Consider importing missing/additional files from Wonder Flags? HOT 3
- Error: invalid tar file when downloading via NPM HOT 1
- When I delete all flags and run download script, Cayman Islands PNG is tiny (36x36px) HOT 1
- Add Russian and Belorussian opposition flags #StandWithUkraine HOT 11
- New region-flags release HOT 12
- Martinique (MQ) flag is outdated HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from region-flags.