Unable to originate call with the CallManager about fonoster HOT 6 CLOSED

@efraa

We need to make several updates to the API, CTL, and Web Application:

• No change needed in the proto definition
• Update API to enforce E.164
• Remove ignoreE164Validation flag from the CallManager service
• Update WebApp to enforce E.164
• Update CTL to enforce E.164
• Update API examples to include + sign

Related work at fix/normalizing-numbers-as-e164

from fonoster.

Video explainer: https://www.loom.com/share/a9ff7d19810145ac84b07e420b5a4f98

from fonoster.

Hi @psanders

from your video, I started to contribute on this: Update API to enforce E.164 and Remove [ignoreE164Validation] flag from the CallManager service
I raised a PR link so we can coordinate together and you can help me to review sooner.

I start to take a look at Update WebApp to enforce E.164

from fonoster.

@efraa this is pretty close to done. We still need to validate the input for the ctl, but we can fix that next week.

from fonoster.

Hi @psanders
About the task Update CTL to enforce E.164, I see that with previous commit the CTL will validate the input from user and enforce E.164

Can you please help to identify what we need to do? Bellow is the result when I run the CTL:

git:(main) ✗ ./run numbers:create
This utility will help you create a new Fonoster Number
Press ^C at any time to quit.
(node:91743) Warning: Setting the NODE_TLS_REJECT_UNAUTHORIZED environment variable to '0' makes TLS connections and HTTPS requests insecure by disabling certificate verification.
(Use node --trace-warnings ... to show where the warning was created)
? number in E.164 format (e.g. +16471234567) 414124
? service provider TX_DEV
? address of record sip:[email protected]
? ready? Yes
Creating Number 414124... done
› Error: 3 INVALID_ARGUMENT: e164Number field must be a valid e164 value.

from fonoster.

@xquanluu Got catch! I missed the fact that this is being validated by the backend.

We are all set here. Thanks.

from fonoster.