Comments (13)
Released as 0.4.1
. =)
from fog-libvirt.
Hello all,
I just updated to foreman 1.15.3. Running debian 8.9 on my foreman host, and the same on my compute hosts. I ran into this issue after updating.
I've manually patched /usr/share/foreman/vendor/ruby/2.1.0/gems/fog-libvirt-0.4.0/lib/fog/libvirt/requests/compute/update_display.rb according to https://github.com/fog/fog-libvirt/pull/43/files on my foreman install and this fixed the issue for me.
Thanks for the patch!
from fog-libvirt.
@santachago could you check if reverting #30 fixes that issue?
from fog-libvirt.
@tbrisker looking at #30 I don't get the whole current situation, as that was also about vnc
from fog-libvirt.
@mmoll IIRC #30 in my case was caused by having a non-auto setting for the keymap, which was failing because fog-libvirt wasn't passing a keymap and libvirt was defaulting to auto (which was different then the existing setting and thus failed to change it). That being said, I think there may be a better solution then this. Sadly I don't have the setup I had previously to try and fix it at the moment.
from fog-libvirt.
If i remove line number 16 -> display[:keymap] = options[:keymap] || xml_elements(domain.xml_desc, "graphics", "keymap")
vms with no keymap defined on the config work fine. If a vm has a value defined it fails with the same error.
from fog-libvirt.
possible fix in #43
from fog-libvirt.
@santachago @tbrisker @mmoll Could you guys please test if master fixed the issue please?
from fog-libvirt.
I can only say it fixed it for me (which is expected as I wrote the patch ;)).
from fog-libvirt.
@santachago any update here?
from fog-libvirt.
@mmoll Thanks for the feeback.
from fog-libvirt.
I guess a 0.4.1 release would be nice then...
from fog-libvirt.
Cuting a release now. =)
from fog-libvirt.
Related Issues (20)
- Disable stale bot? HOT 4
- list_domains:domains_volumes only parses <source file=...> HOT 7
- Question: Current use of filters in requests can result in test code being unable to exercise behaviour
- Ask for merge and release permissions HOT 8
- Port defaults to -1 HOT 3
- Swapping media HOT 3
- new gem release? HOT 2
- Cloning volumes from templates when creating new VMs HOT 4
- minitest/unit.rb:28:in `const_missing': uninitialized constant MiniTest::Test (NameError) HOT 6
- Lack of macvlan/macvtap support HOT 5
- Ceph RBD volume creation HOT 3
- qemu-guest-agent support HOT 5
- Change dependency on fog-core to something recent HOT 3
- Failure during ansible provisioning HOT 1
- cloud-init iso using mkisofs HOT 1
- Adding Xen support. HOT 3
- volume filters always returns volume object when no match found HOT 2
- Q35 chipset support? HOT 12
- 0.8.0 missing from github release, also changelog HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fog-libvirt.