Giter Club home page Giter Club logo

Comments (13)

plribeiro3000 avatar plribeiro3000 commented on August 23, 2024 3

Released as 0.4.1. =)

from fog-libvirt.

hesperaux avatar hesperaux commented on August 23, 2024 1

Hello all,

I just updated to foreman 1.15.3. Running debian 8.9 on my foreman host, and the same on my compute hosts. I ran into this issue after updating.

I've manually patched /usr/share/foreman/vendor/ruby/2.1.0/gems/fog-libvirt-0.4.0/lib/fog/libvirt/requests/compute/update_display.rb according to https://github.com/fog/fog-libvirt/pull/43/files on my foreman install and this fixed the issue for me.

Thanks for the patch!

from fog-libvirt.

mmoll avatar mmoll commented on August 23, 2024

@santachago could you check if reverting #30 fixes that issue?

from fog-libvirt.

mmoll avatar mmoll commented on August 23, 2024

@tbrisker looking at #30 I don't get the whole current situation, as that was also about vnc

from fog-libvirt.

tbrisker avatar tbrisker commented on August 23, 2024

@mmoll IIRC #30 in my case was caused by having a non-auto setting for the keymap, which was failing because fog-libvirt wasn't passing a keymap and libvirt was defaulting to auto (which was different then the existing setting and thus failed to change it). That being said, I think there may be a better solution then this. Sadly I don't have the setup I had previously to try and fix it at the moment.

from fog-libvirt.

santachago avatar santachago commented on August 23, 2024

If i remove line number 16 -> display[:keymap] = options[:keymap] || xml_elements(domain.xml_desc, "graphics", "keymap")

vms with no keymap defined on the config work fine. If a vm has a value defined it fails with the same error.

from fog-libvirt.

mmoll avatar mmoll commented on August 23, 2024

possible fix in #43

from fog-libvirt.

plribeiro3000 avatar plribeiro3000 commented on August 23, 2024

@santachago @tbrisker @mmoll Could you guys please test if master fixed the issue please?

from fog-libvirt.

mmoll avatar mmoll commented on August 23, 2024

I can only say it fixed it for me (which is expected as I wrote the patch ;)).

from fog-libvirt.

mmoll avatar mmoll commented on August 23, 2024

@santachago any update here? ☝️

from fog-libvirt.

plribeiro3000 avatar plribeiro3000 commented on August 23, 2024

@mmoll Thanks for the feeback. 👍

from fog-libvirt.

mmoll avatar mmoll commented on August 23, 2024

I guess a 0.4.1 release would be nice then...

from fog-libvirt.

plribeiro3000 avatar plribeiro3000 commented on August 23, 2024

Cuting a release now. =)

from fog-libvirt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.