[2.4.4] dist/focustrap.js doesn't exist about focus-trap HOT 4 CLOSED

Thanks, @jeroencornelissen. Should be fixed in 2.4.5.

from focus-trap.

@davidtheclark Actually, now it is fully broken 😢

If someone tries to use it from unpkg.com they'll get error due to require not being implemented:
https://jsbin.com/remegiyeva/edit?html,console
However if you point to dist/focus-trap.js; which should be where main points to; you get this:
https://jsbin.com/nagicadifu/edit?html,console

Bottom line, main should always point to the umd bundle 😉

from focus-trap.

@vladimyr Are you sure you're looking in the right place, according to https://github.com/davidtheclark/focus-trap#installation?

https://unpkg.com/[email protected]/dist/focus-trap.js and https://unpkg.com/[email protected]/dist/focus-trap.min.js exist and seem to work fine.

In 2.4.5 main actually points to index.js, not to dist/focus-trap.js.

Bottom line, main should always point to the umd bundle 😉

I don't agree, because that adds unnecessary stuff for module users.

from focus-trap.

@vladimyr Are you sure you're looking in the right place, according to https://github.com/davidtheclark/focus-trap#installation?

Yeah, you are right, I missed that one 🤦‍♂️ Although it should be probably more helpful if documentation gives you something like this:

<!-- development -->
<script src="https://unpkg.com/[email protected]/dist/focus-trap.js"></script>

<!-- production -->
<script src="https://unpkg.com/[email protected]/dist/focus-trap.min.js"></script>

because Vue does that and React used to show that <script> snippet on their homepage too... It is easier if you can just c/p it 🙂

I don't agree, because that adds unnecessary stuff for module users.

Well, technically speaking it does add umd wrapper bloat and I'm perfectly aware that at the end of the day it is your call to decide. However, just in case you missed it, all packages listed on unpkg.com homepage except react & react-dom (Vue is not listed there but points to umd bundle too) do the opposite so you are kinda going against the flow...
To be totally fair they mostly do it using unpkg field in package.json with three.js being exception by using main.

IMHO it is all about user expectations; user should be able to do following:

<script src="https://unpkg.com/[email protected]"></script>

without getting any errors and going to github/unpkg to figure out what path to append there.

from focus-trap.