Comments (6)
This is how I used that with KendoUI:
focusTrap(myPopup, {
includeOutsideElement (element) {
return !!element.closest('.k-animation-container') // all KendoUI pickers have this class
}
})
from focus-trap.
Hello @gejgalis. I have a question: When a DatePicker opens, shouldn't focus be able to enter that picker? If includeOutsideElement
only allows clicks in the outside element, you can't get to the outside element by tabbing, right?
If you agree that we may want to allow focus to move between the elements (the original form and the displaced DatePicker), maybe the solution is to allow focus trap to accept multiple elements?
from focus-trap.
Hello @davidtheclark . Kendo pickers prevents mousedown event, so you can't jump with focus from date input to date picker - you can only use a mouse to choose a day, so focus always stays in date input. See date picker demo
Allowing multiple elements upfront as one logical trap container is not always possible (using HTMLElement reference), because some of those elements are created dynamically after click. It would be only possible by configuring string selector (not HTMLElement reference). If you are OK with that - it will work for me too.
from focus-trap.
@davidtheclark you want me to prepare PR for multiple targets?
from focus-trap.
@gejgalis Sorry for the delayed answer here. If you're still interested in trying to add this feature, I'm open to a PR.
from focus-trap.
This is certainly an edge case and nobody has yet finished a PR with a workable API. So I'm going to close this issue for now. If you are invested in this use case and want to work out the details with me, please open a new issue.
from focus-trap.
Related Issues (20)
- Adjust types to allow `initialFocus: () => undefined` HOT 4
- Bug with selecting jumping to first tabbable from last if web component is involved. HOT 5
- Disabling the focus trap loop HOT 6
- Unable to preventDefault inside passive event listener invocation. HOT 9
- Cannot tab on to or past a web-component in a container HOT 6
- Setting initialFocus=true leads to a call stack exceeded exception HOT 2
- More Flexible Mocking in Unit Tests HOT 3
- The library is not working HOT 3
- Should focusTrap only activate connected nodes? HOT 3
- Broken in Safari HOT 4
- focusIn listener causes issues with outside elements HOT 15
- Stack overflow tryFocus/checkFocusIn HOT 10
- Can't focus other textfields while focusing on autocomplete HOT 2
- Text selection within trapped element not possible if any ancestor has a `tabindex` HOT 9
- `returnFocusOnDeactivate` not working on mobile. HOT 9
- Focus does not seem to be working on firefox HOT 6
- Update type for document option to allow for shadowRoot elements. HOT 7
- "default behavior" demo broken on Firefox HOT 4
- Clicking another shadowed element inside the focus trap will deactivate the focus trap HOT 15
- focus-trap returns an error on Safari 15.3 and lower HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from focus-trap.