Giter Club home page Giter Club logo

Comments (6)

gejgalis avatar gejgalis commented on June 16, 2024

This is how I used that with KendoUI:

focusTrap(myPopup, {
  includeOutsideElement (element) {
     return !!element.closest('.k-animation-container') // all KendoUI pickers have this class
  }
})

from focus-trap.

davidtheclark avatar davidtheclark commented on June 16, 2024

Hello @gejgalis. I have a question: When a DatePicker opens, shouldn't focus be able to enter that picker? If includeOutsideElement only allows clicks in the outside element, you can't get to the outside element by tabbing, right?

If you agree that we may want to allow focus to move between the elements (the original form and the displaced DatePicker), maybe the solution is to allow focus trap to accept multiple elements?

from focus-trap.

gejgalis avatar gejgalis commented on June 16, 2024

Hello @davidtheclark . Kendo pickers prevents mousedown event, so you can't jump with focus from date input to date picker - you can only use a mouse to choose a day, so focus always stays in date input. See date picker demo

Allowing multiple elements upfront as one logical trap container is not always possible (using HTMLElement reference), because some of those elements are created dynamically after click. It would be only possible by configuring string selector (not HTMLElement reference). If you are OK with that - it will work for me too.

from focus-trap.

gejgalis avatar gejgalis commented on June 16, 2024

@davidtheclark you want me to prepare PR for multiple targets?

from focus-trap.

davidtheclark avatar davidtheclark commented on June 16, 2024

@gejgalis Sorry for the delayed answer here. If you're still interested in trying to add this feature, I'm open to a PR.

from focus-trap.

davidtheclark avatar davidtheclark commented on June 16, 2024

This is certainly an edge case and nobody has yet finished a PR with a workable API. So I'm going to close this issue for now. If you are invested in this use case and want to work out the details with me, please open a new issue.

from focus-trap.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.