Giter Club home page Giter Club logo

Comments (2)

davidtheclark avatar davidtheclark commented on September 21, 2024

Interesting point, @jessemc98. However, I don't think that the issue is within the domain of this library. A focus-trap does not enable and disable the ability to focus elements: instead, it traps focus within a set of focusable elements. If you want to make a previously focusable element unfocusable, you can do so with some other JS — but that seems unrelated to the focus-trapping problem this library is meant to solve.

from focus-trap.

jessemc98 avatar jessemc98 commented on September 21, 2024

Thanks for the hasty reply,

I guess you're right, I just thought it might be a useful feature since it is a pretty common use case in most sites with a mobile navigation and it would take away the need to query the dom for the focusables twice.

I see your point, separation of concerns is important but the only time where I can see the feature I described being useful is when using a focus trap.

from focus-trap.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.