Comments (2)
davidtheclark
commented on August 20, 2024
What if you set the focus-trap option returnFocusOnDeactivate: false? See https://github.com/davidtheclark/focus-trap#focustrap--createfocustrapelement-createoptions
from focus-trap-react.
jameschetwood
commented on August 20, 2024
returnFocusOnDeactivate is already set to false. returnFocusOnDeactivate works great except sometimes the button that triggered the modal no longer exists by the time the modal is closed, in which case I need to focus on a different button.
Also modals are controlled by the url hash so they're kinda 'global' rather than being within a component in the normal React way. This is why there's some weirdness in componentDidUpdate. To be honest this has turned out to be really problematic and will need refactoring so no worries if there's no easy solution. Turns out breaking React's component modal was a bad call, who knew? ;-)
I'm happy for you to close this issue.
from focus-trap-react.
Related Issues (20)
- Question - `tabbable` mocking in vitest HOT 3
- 'FocusTrap' cannot be used as a JSX component. HOT 2
- Files not found on demo website HOT 6
- Loosing focus after second popup opening with Redux Form HOT 3
- the demo is broken HOT 4
- Not working for me HOT 4
- Weird behaviour when used inside shadow DOM. Input loses focus when pressing "Delete" key HOT 4
- Doesn't work if child of FocusTrap is React component created using classes HOT 7
- Having an issue with trapping focus working on just the first and last element HOT 5
- Unknown Your focus-trap must have at least one container with at least one tabbable node in it at all times error HOT 11
- Conditionally rendering FocusTrap causes immediate deactivation with Strict Mode HOT 22
- How to avoid initial focus on Focus-Trap? HOT 3
- Add option to retain ability to click with mouse on outside elements HOT 3
- TypeError: Cannot read properties of undefined (reading 'contains') HOT 18
- Unable to install without legacy-peer-deps HOT 2
- Callback props don't seem to update with state changes HOT 5
- Add onPost/Pause and onPost/Unpause hooks HOT 1
- Focus jumps to body when updating content inside FocusTrap HOT 13
- SyntaxError: 'slot):not([inert]' is not a valid selector HOT 14
- Error: Uncaught [SyntaxError: 'slot):not([inert]' is not a valid selector] HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from focus-trap-react.