MSVC Compile error about sqlite_orm HOT 4 CLOSED

Hi. Thanks for using the lib. I with my lib to have a perfect windows compatibility but travis CI doesn't support windows and I seldom write software targeted for OS windows. That's why your issue is very important. Please answer two questions:

1. doesn't MS Visual Studio support and and or C operators? If so where can I get info about this?
2. why do you add __RESTORE_MIN__ and __RESTORE_MAX__ conditional compilation blocks?

I'm looking forward adding MSVC support so please help me with that. Thanks

from sqlite_orm.

A1.
First, I used AppVeyor's Visual Studio 2015. It will not compile normally in this environment.

• Related documents: https://msdn.microsoft.com/en-US/library/2e6a4at9.aspx
• Latest related documents: https://docs.microsoft.com/ko-kr/cpp/cpp/keywords-cpp

A2.
If you use Windows.h (include minwindef.h), You can use the NOMINMAX macro to prevent redefine of min/max. Considering this situation, I used __RESTORE_MIN__ to prevent __pragma(pop_macro("min")) macro.

I hope this answer helps you.

from sqlite_orm.

Ok. I see that my lib got to have some changes to compile well with MSVC. Does your code compile well after your modifications? If yes please submit a pull request

from sqlite_orm.

Is the issue active?

from sqlite_orm.