General improvements & tweaks for MSVC about sqlite_orm HOT 6 CLOSED

removed exception specifications

from sqlite_orm.

refactored enable_if to optional argument like typename std::enable_if<cond>:type * = nullptr

from sqlite_orm.

@jamboree didn't find this things in code "Don't name a variable with the something that's already declared. e.g. you have template table and local variable table, this confuses MSVC.". I changed table member call with this->table to be safe and it turned out that there is no local variable called table at all. Could you please provide line number in last commit? Thanks

from sqlite_orm.

@fnc12 Sorry it's indeed a data member, didn't look carefully. I think I can just make a pull request to fix the issues.

from sqlite_orm.

@jamboree I merged your pull request. I fixed the only thing: replaced std::bool_constant with std::integral_cosntant<bool> cause std::bool_constant is C++17 feature. Now the only issue point left is "Don't name a variable with the something that's already declared. e.g. you have template table and local variable table, this confuses MSVC.". Is it gotta be fixed or what? If not I close the issue

from sqlite_orm.

Yes this->table fixed the problem.

from sqlite_orm.