clang-tidy warnings about faudio HOT 5 CLOSED

Some commits to deal with these warnings:

5609c6b
ab45f64
8781641
87bfe65

Probably won't modify any of the stb_vorbis stuff unless Sean is interested in those changes.

from faudio.

This all works for me - ran the tool locally (F28 version) and the build/output seems good. Glad that I can start using this stuff again... let's make sure this keeps working throughout the rest of the CMake work.

from faudio.

The break condition is definitely crappy, but at the same time the code should always break in the middle. If nothing else uses i we can change to an int32_t and that'll make it safer, but maybe we can make this loop nicer in general.

from faudio.

FYI: you can detect more of them by using e.g. clang-tidy.

clang-tidy can utilize compile_commands.json generated for Ninja, so I'm usually using it like this:

meson --prefix /tmp/faud /tmp/faud64
cd /tmp/faud64
/usr/lib/llvm/7/share/clang/run-clang-tidy.py -header-filter='.*' \
-extra-arg="-DHAVE_FFMPEG" -extra-arg="-isystem/usr/include/SDL2" \
-checks='-clang-diagnostic-unused-command-line-argument,-clang-diagnostic-implicit-function-declaration' -quiet

Output: FAudio-clang-tidy-output.txt

Checks and descriptions: https://clang.llvm.org/extra/clang-tidy/checks/list.html

Example2: all checks disabled, except bugprone-* ones, and "auto-fix" (if possible) allowed

$ clang-tidy -header-filter=.* -checks=-*,bugprone-* -extra-arg=-isystem/usr/include/SDL2 -p=/tmp/faud64 -quiet -fix /tmp/FAudio/src/XNA_Song.c

from faudio.

clang tidy can also be started directly through cmake, just tried it with the following commands

cmake -H. -B_build -DCMAKE_C_CLANG_TIDY=clang-tidy -DCMAKE_CXX_CLANG_TIDY=clang-tidy  -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++
cmake --build _build

this builds libFAudio.so with clang and outputs clang-tidy warnings while building.

from faudio.