Giter Club home page Giter Club logo

Comments (12)

swsnr avatar swsnr commented on May 17, 2024

This is intentional.

from flycheck.

wyuenho avatar wyuenho commented on May 17, 2024

Mmm ok so I guess you are aiming for granularity. Is there a way I can get the whole token highlighted instead of just the column?

from flycheck.

swsnr avatar swsnr commented on May 17, 2024

I'll make it customizable.

from flycheck.

wyuenho avatar wyuenho commented on May 17, 2024

πŸ‘

from flycheck.

wyuenho avatar wyuenho commented on May 17, 2024

Just discovered another problem with this change, sometimes checkers like jshint will report an error on a column that is a space, e.g a defined but unused variable, jshint will report the column that is the space right after the unused variable. This change doesn't highlight spaces in the middle of a line. This may affect PR #39 too, as some checkers report trailing whitespace errors, but that's not highlighted in PR #39.

from flycheck.

swsnr avatar swsnr commented on May 17, 2024

Sorry, but I fail to understand what you're trying to tell me. I guess the jshint checker somehow highlights the wrong column or so. If so that is a bug. In this case please report it as new issue, and include the following in your description:

  • The source code that is checked.
  • The output of the checker if run from command line with the same arguments flycheck uses.
  • A screenshot of the highlighting you observe
  • A description of the highlighting that you'd expect, at best an exact range of positions that you'd like to see highlighted.

from flycheck.

wyuenho avatar wyuenho commented on May 17, 2024

Screen Shot 2013-01-03 at 3 47 18 AM

Error Message:

lib/backbone-pageable.js: line 399, col 23, 'lastPage' is defined but never used.

The point is where the error column is. Currently it is not hightlighted because it's a space. It's not an error from jshint, I'd expect that space to be hightlighted by flycheck.

from flycheck.

swsnr avatar swsnr commented on May 17, 2024

I'm sorry but that is not something Flycheck can fix. The default faces of Emacs are simply ill-suited to highlight errors, because they lack β€œcatchiness” and cannot highlight spaces though spaces can actually be errors (think of trailing spaces that are forbidden by many style guides and hence warned about by many syntax checkers).

Really, really use reasonable faces that have a striking background color and/or an underline, like in the screenshot in README.md.

from flycheck.

swsnr avatar swsnr commented on May 17, 2024

I'll document that, though.

from flycheck.

wyuenho avatar wyuenho commented on May 17, 2024

Ah right. Good deal.

from flycheck.

swsnr avatar swsnr commented on May 17, 2024

Do you think dd0fe96 provides enough information?

from flycheck.

swsnr avatar swsnr commented on May 17, 2024

Note that I changed the customization setting to disable column-specific highlighting.

Replace (setq flycheck-ignore-columns t) with (setq flycheck-highlighting-mode 'lines).

from flycheck.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.