Progress deadline exceeded not triggering a rollback during promotion about flagger HOT 4 CLOSED

Here is a preview image that contains a fix for this bug: ghcr.io/fluxcd/flagger:rc-bb949c08. We would appreciate it if you could try it and confirm whether the fix works. Thanks! :)

from flagger.

Thanks for looking at this @aryan9600, much appreciated.

Just giving this a test, and functionally it looks great thanks.
It would be great if a exceeded its progress deadline event was triggered, if that didn't had too much complexity and if that is what is actually happening.

from flagger.

If I'm understanding correctly, you'd like an event to be emitted when a exceeded its progress deadline error is encountered? If so, that is the present behavior of Flagger, it emits an event with type "Warning".

from flagger.

So using this rc image I didn't see that event. The events appear as follows is this scenario

  Normal   Synced  3m34s              flagger  Advance my-service.my-namespace canary weight 20
  Warning  Synced  5s (x7 over 3m5s)  flagger  my-service.my-namespace not ready: waiting for rollout to finish: 0 of 1 (readyThreshold 100%) updated replicas are available
  Warning  Synced  5s (x7 over 3m5s)  flagger  my-service.my-namespace not ready: waiting for rollout to finish: 0 of 1 (readyThreshold 100%) updated replicas are available
  Warning  Synced  5s                 flagger  Canary failed! Scaling down my-service.my-namespace

I have Progress Deadline Seconds: 180 which looks to be the period it's waiting before failing, but that event doesn't appear

from flagger.