Giter Club home page Giter Club logo

Comments (6)

MarkOSullivan94 avatar MarkOSullivan94 commented on July 18, 2024 1

@alextekartik version 0.7.0 released! This should fix your issue.

from flutter_launcher_icons.

MarkOSullivan94 avatar MarkOSullivan94 commented on July 18, 2024

Hi, thanks for filing an issue with the package.

Curious, does it work for you if you have image_path by itself (no image_path_ios) and ios: true along with android: false?

I would recommend sticking to using just image_path unless you definitely need to specify separate icons for Android and iOS, then you should be using both image_path_ios & image_path_android.

That being said, it's unexpected behaviour for it not to work with just image_path_ios provided so I'll look to get this fixed in the next update.

from flutter_launcher_icons.

alextekartik avatar alextekartik commented on July 18, 2024

As i said if I add an image_path, it does generate the android icons even though it is set to false...No urgency, my workaround was to simply revert the changes in the android folder.

from flutter_launcher_icons.

MarkOSullivan94 avatar MarkOSullivan94 commented on July 18, 2024

Yep that's definitely a bug. I'll get a fix for it in the next update.

Thanks for reporting it and apologies for the inconvenience.

from flutter_launcher_icons.

MarkOSullivan94 avatar MarkOSullivan94 commented on July 18, 2024

Hi @alextekartik, I've finally got round to getting this finished off tonight.

For safe measures, I've added a couple of unit tests to ensure that there are checks for both iOS and Android to see if new icons are needed to be generated. Should hopefully avoid any future issues with this!

iOS
c7a5837#diff-fe53fad46868a294b309fc85ed138997R76

Android
c7a5837#diff-fe53fad46868a294b309fc85ed138997R57

I'll keep this open until the next version is released and will ping you then.

If you want to test it out before then, you can specify flutter_launcher_icons to use the master branch of this repo. I've done something similar to maintain my own version of dart_config to ensure that package doesn't update and break flutter_launcher_icons.

https://github.com/fluttercommunity/flutter_launcher_icons/blob/master/pubspec.yaml#L15

from flutter_launcher_icons.

alextekartik avatar alextekartik commented on July 18, 2024

Thanks! I don't generate icons every day (i.e. unless I change my icon) so will keep you posted when I try again. As a side note, my biggest fear when I tried it is that we had to put our config in our pubspec.yaml. Maybe this tool could be an external tool (i.e. no need to put it as a dependency) that we could use by specifying a folder and a config file.

from flutter_launcher_icons.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.