Giter Club home page Giter Club logo

Comments (14)

 avatar commented on July 18, 2024 1

@MarkOSullivan94
I tried the example in this repo.
Got the same sorts of errors when i flipped it to actually generate the IOS icons ontop of the standad ones. By default the example does not gen the icons for IOS.

flutter_icons:
  image_path: "assets/images/icon-128x128.png"
  android: true
  ios: true


x-MacBook-Pro:example apple$ flutter run
Launching lib/main.dart on iPhone 8 Plus in debug mode...
Skipping compilation. Fingerprint match.
Starting Xcode build...                                          
 ├─Assembling Flutter resources...                    1.7s
 └─Compiling, linking and signing...                  2.5s
Xcode build done.                                            5.9s
Failed to build iOS app
Error output from Xcode build:
↳
    ** BUILD FAILED **
    
Xcode's output:
↳
    /* com.apple.actool.errors */
    /Users/apple/workspace/go/src/github.com/franzsilva/flutter_launcher_icons/example/ios/Runner/Assets.xcassets: error: None of the input catalogs contained a matching stickers icon set or app icon set named  "Icon-App".
    /* com.apple.actool.document.warnings */
    /Users/apple/workspace/go/src/github.com/franzsilva/flutter_launcher_icons/example/ios/Runner/Assets.xcassets:./AppIcon.appiconset/(null)[2d][[email protected]]: warning: The app icon set "AppIcon" has 2 unassigned children.
    /Users/apple/workspace/go/src/github.com/franzsilva/flutter_launcher_icons/example/ios/Runner/Assets.xcassets:./My-Test-Icon.appiconset/(null)[2d][[email protected]]: warning: The app icon set "My-Test-Icon" has 3 unassigned children.
    /* com.apple.actool.compilation-results */
    /Users/apple/Library/Developer/Xcode/DerivedData/Runner-ecbnrdgjcowwknalphzxvqxzlhtp/Build/Intermediates.noindex/Runner.build/Debug-iphonesimulator/Runner.build/assetcatalog_generated_info.plist
    
Could not build the application for the simulator.
Error launching application on iPhone 8 Plus.

from flutter_launcher_icons.

 avatar commented on July 18, 2024 1

@MarkOSullivan94 thanks dude !

Will test it here when you think its ready for another go :)

thanks too for this plugin.

from flutter_launcher_icons.

 avatar commented on July 18, 2024 1

still busted for me. Bu then again you did not publish version 0.2.2

Can i suggest you make a ci pipelne on bitrise.
Its really easy and it will run full builds for IOS and Android.
Then you can know it works !

heres a make file to get your going.
Alot of the bits you dont need but it will definitely get you going as you can see the relevent commands


DIR=$(shell pwd)

DIST_FSPATH=$(DIR)/dist
LIB_DK_GOPATH=github.com/zserge/webview
LIB_DK_FSPATH=$(GOPATH)/src/$(LIB_DK_GOPATH)

check:
	@echo DIST_FSPATH : $(DIST_FSPATH)
	@echo LIB_DK_GOPATH : $(LIB_DK_GOPATH)
	@echo LIB_DK_FSPATH : $(LIB_DK_FSPATH)

	flutter doctor -v
	bitrise setup --full
	bitrise validate
	
## Global cloud dep

dep-cloud:
	# todo update all cloud dependencies.


## OS dep

dep-os:

	# go
	brew install dep

	# flutter 

	# ci
	brew install bitrise

	curl -fL https://github.com/bitrise-io/bitrise/releases/download/1.13.0/bitrise-$(uname -s)-$(uname -m) > /usr/local/bin/bitrise
	chmod +x /usr/local/bin/bitrise

dep-os-update:

	# update go tools
	brew upgrade dep
	brew upgrade bitrise

	# flutter. global package update
	flutter update-packages
	
## local dep

dep:
	# golang (change to dep laters ...)
	go get $(LIB_DK_GOPATH)

	# go sentry for crash analytics
	go get github.com/getsentry/raven-go
	# dart sentry 
	#github.com/flutter/crashy

	# flutter
	cd mobile/app01 && flutter packages get
	cd mobile/app01 && flutter packages get

dep-clean:
	rm -rf $(LIB_DK_FSPATH)

dep-update:

	# dep for golang

	# flutter
	cd mobile/app01 && flutter packages upgrade

dep-list:

	dep list

	# flutter
	cd mobile/app01 && flutter packages upgrade

## Dev Build

build-dk:
	# desktop
	cd desktop && go build -o $(DIST_FSPATH)/dk main.go 



open-mb-ios:
	# mobile open in xcode
	cd mobile/app01/ios && open Runner.xcodeproj 
	open https://itunesconnect.apple.com/WebObjects/iTunesConnect.woa/ra/ng/app/1349333098

build-mb-ios:
	# mobile
	open -a Simulator.app
	cd mobile/app01 && flutter run

build-mb-ios-release:
	# Must build release in order to archive.
	# In XCOde must change to IOS 11, because Flutter only supports arm64. Check with google !!
	cd mobile/app01 && flutter build ios --release
	# Now open in xcode and do archive. It should work and be ready for Upload !!


## Dev CI

ci-setup:
	# once
	bitrise update
	bitrise init

ci-edit:
	bitrise :workflow-editor

ci-run:
	bitrise run primary
	

ci-codesign-ios:
	# in order to get xcode 
	#cd mobile/app01/ios && 1.sh




from flutter_launcher_icons.

 avatar commented on July 18, 2024 1

ah sorry missed that..

Yep it works for me :)
I did a fresh pull, generated an icon and run it in ios.

It will take about 5 minutes to get it in CI with bitrise btw.
I will share one with you via bitrise...

from flutter_launcher_icons.

 avatar commented on July 18, 2024

so my first mistake was using a base icon that had the wrong aspect ratio.
now i have 2 errors :)


Xcode's output:
↳
    === BUILD TARGET Runner OF PROJECT Runner WITH CONFIGURATION Debug ===
    The use of Swift 3 @objc inference in Swift 4 mode is deprecated. Please address deprecated @objc inference warnings, test your code with “Use of deprecated Swift 3 @objc inference”logging enabled, and then disable inference by changing the "Swift 3 @objc Inference" build setting to "Default" for the "Runner" target.
    === BUILD TARGET Runner OF PROJECT Runner WITH CONFIGURATION Debug ===
    /* com.apple.actool.errors */
    /Users/apple/workspace/go/src/bitbucket.org/gedw99/md-flutter/sdk/ci/flutter/hello/example/ios/Runner/Assets.xcassets: error: None of the input catalogs contained a matching stickers icon set or app icon set named  "Icon-App".
    /* com.apple.actool.document.warnings */
    /Users/apple/workspace/go/src/bitbucket.org/gedw99/md-flutter/sdk/ci/flutter/hello/example/ios/Runner/Assets.xcassets:./AppIcon.appiconset/(null)[2d][[email protected]]: warning: The app icon set "AppIcon" has an unassigned child.
    /* com.apple.actool.compilation-results */
    /Users/apple/workspace/go/src/bitbucket.org/gedw99/md-flutter/sdk/ci/flutter/hello/example/build/ios/Debug-iphonesimulator/Runner.app/Assets.car
    /Users/apple/Library/Developer/Xcode/DerivedData/Runner-dtbkweoretbigafrvarnpjyccwxb/Build/Intermediates.noindex/Runner.build/Debug-iphonesimulator/Runner.build/assetcatalog_generated_info.plist

from flutter_launcher_icons.

 avatar commented on July 18, 2024

the bug is that you output this file:
[email protected]
also remove its reference from the Contents.json

then it all works.

also you might want to mention that you have to start with a correct icon aspect ratio in the first place.
i figured your code would resize & chop to the correct size but it does not.

from flutter_launcher_icons.

MarkOSullivan94 avatar MarkOSullivan94 commented on July 18, 2024

Are you having the same issues while running the example project in the GitHub repo?

from flutter_launcher_icons.

 avatar commented on July 18, 2024

@MarkOSullivan94
No. I am generating my own flutter project using:

flutter create --org com.gedw99 --template=plugin -i swift -a kotlin hello

See the Steps to Reproduce at the top.

from flutter_launcher_icons.

 avatar commented on July 18, 2024

i cant work out what its yelling about.
XCode project files are baffling ...

from flutter_launcher_icons.

MarkOSullivan94 avatar MarkOSullivan94 commented on July 18, 2024

I need to investigate this whenever I'm free to figure out what's gone wrong and will release a fix ASAP. Thanks for reporting the issue!

from flutter_launcher_icons.

MarkOSullivan94 avatar MarkOSullivan94 commented on July 18, 2024

Just tested it out here on my laptop and I'm getting the same issue

from flutter_launcher_icons.

MarkOSullivan94 avatar MarkOSullivan94 commented on July 18, 2024

@gedw99 I've switched pubspec.yaml to use this repo's version of Flutter Launcher Icons. I should have fixed the issue for overriding the default iOS icon. Pull the latest changes and rerun the example and let me know if you're having any issues (might be good to see if I've messed up saving new icons and not just overwriting the old iOS icons).

Right now the plugin definitely seems to have issues with using an image which don't have to same aspect ratio as the desired icon dimensions.

I'm not sure what can be done with the aspect ratio (if anything) and couldn't see anything tonight from a brief search so will need to do further investigation to see if we can support images which don't have the same aspect ratio, otherwise we'll have to show an error message to the user when running the plugin.

from flutter_launcher_icons.

MarkOSullivan94 avatar MarkOSullivan94 commented on July 18, 2024

still busted for me. Bu then again you did not publish version 0.2.2

That's why I asked you to run the example project instead (it's using a local version of Flutter Launcher Icons). I'm not going to publish another version to the Dart Package repo until I know it's fixed.

from flutter_launcher_icons.

MarkOSullivan94 avatar MarkOSullivan94 commented on July 18, 2024

Definitely want to look into some form of CI down the line and I appreciate the recommendation!

from flutter_launcher_icons.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.