Giter Club home page Giter Club logo

Comments (8)

gaaclarke avatar gaaclarke commented on June 1, 2024

Here is a successful run from yesterday, it doesn't print out that warning at the clobber step: https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20Engine%20Drone/856718/overview

That seems to indicate that is a valid warning that should be investigated.

from flutter.

gaaclarke avatar gaaclarke commented on June 1, 2024

I'm dropping this to p1 since it seems that when you play bot roulette you may get one not in a bad state.

from flutter.

zanderso avatar zanderso commented on June 1, 2024

https://flutter-review.googlesource.com/c/recipes/+/57400 <- forces the cache to be remounted, which should avoid the inconsistency until the cache is back in a good state.

from flutter.

christopherfujino avatar christopherfujino commented on June 1, 2024

Once the caches are back in a good state, we should revert https://flutter-review.googlesource.com/c/recipes/+/57400

from flutter.

gaaclarke avatar gaaclarke commented on June 1, 2024

I don't understand the code, but would it be preferable not to revert that CL? It seems like slower but more correct builds would be preferable. An optimization that requires manual massaging doesn't seem like a good tradeoff these days.

from flutter.

christopherfujino avatar christopherfujino commented on June 1, 2024

I don't understand the code, but would it be preferable not to revert that CL? It seems like slower but more correct builds would be preferable. An optimization that requires manual massaging doesn't seem like a good tradeoff these days.

That's a fair question. My sense is this doesn't happen that often, so not sure it's worth increased build time, but I have no strong opinion either way.

from flutter.

zanderso avatar zanderso commented on June 1, 2024

If there are no obvious negative side-effects (like builds timing out and turning the tree red), we can leave it landed for the rest of the week, and I'll monitor the build cycle time chart to look for large changes to the average build times.

from flutter.

zanderso avatar zanderso commented on June 1, 2024

The builds are slightly longer, but are finishing within existing timeouts, so I'll close this.

from flutter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.