exeption thrown in queryTextActions while opening a dialog in MacOS about flutter HOT 7 CLOSED

Thanks for the report. 👍

this exception is caught so I'm not sure if it's an actual issue

I introduced this issue, at that time I did not realize that while the exception is caught it could be annoying when tooling is set to break on all exceptions, for instance on VSCode:

This was fixed on master and beta by #141205.
For more details, see #144505 (comment).

from flutter.

Interesting.
From the Dart page you pointed, my reading of "Exceptions are errors indicating that something unexpected happened. ", is that 'unexpected' does not apply to this specific case (checking if the result of queryTextActions is null as I did initially).

as a Flutter developer, you have different constraints than an App developer?

I think every frameworks and apps set their own priorities. For Flutter, developper experience is a very high priority (see https://github.com/flutter/flutter/wiki/Values#-focus-on-the-user-and-all-else-will-follow). That's why the annoyance of having VS debugger (and probably other debuggers) stopping on this particular exception had to be considered (especially because, in this particular case, there was a more developper friendly alternative).

from flutter.

Thanks @bleroux for the tip.

@stephane-archer I verified this on master and didn't get any exception while opening the dialog running the code sample on desktop, mobile and web platforms.
Based on above comment and since the fix is in place in master, I'll close this as fixed per triage policy. If you disagree, write in comments and I'll reopen it.

from flutter.

thanks, @bleroux and @darshankawar for being so reactive, so from my understanding, Dart recommended error handling is to use exception but the Flutter team can not use that because of VScode 😅. https://dart.dev/language/error-handling

from flutter.

thanks, @bleroux and @darshankawar for being so reactive,

🙏

so from my understanding, Dart recommended error handling is to use exception but the Flutter team can not use that because of VScode 😅. https://dart.dev/language/error-handling

Not exactly, here I made a basic mistake 😅 which was to rely on exception for a non-exceptionnal case which was queryTextActions returning null. It is non-exceptionnal because this is intended on platforms that does not implement this feature on the engine side and it was possible to take care of this case without relying on exception.

from flutter.

@bleroux you mention that exceptions should be used only for exceptional cases, and while it is true for some languages (C++, Go), the documentation of Dart only mentions for error handling to use exceptions https://dart.dev/language/error-handling
Exceptions usually simplify the return types of the API and help separate the bad and the happy paths.
In some languages, it's the preferred way for error handling.
Reading the documentation I understood that exceptions could be used not only for exceptional cases.
Do you know if my understanding was wrong or is it because as a Flutter developer, you have different constraints than an App developer?

from flutter.

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

from flutter.