There's no PWA icon about flus HOT 5 CLOSED

No problem, good luck with all your work! ✨

from flus.

Hey @mielp, I think I never mentioned Flus works as a PWA since it never has been my intention :p I most probably said it's working fine on mobile (implying in a browser). I agree though that having a simple webmanifest would enhance the experience a lot, I'm adding your suggestion to my list. I'll let you know when it'll be done :) Thanks for your suggestion!

from flus.

Oh, my mistake then, I mixed up the concepts 😅

I don't know PHP at all, but if it's just about writing a decent manifest file in the static directory and referencing it in the five-ish PHTML layouts the same way the favicon-32px.png file is referenced, then I can make the change if you want?

from flus.

I don't think it should be in the static/ directory (because of the name and start_url which can be changed), so it might be a bit more complicated than what you expect.

Also, for the moment, I don't want to encourage PR from other people because it will ask me time/energy to review and integrate. I already have enough to do 😅

from flus.

Hey @mielp, the webmanifest has been added in #175 and it is now deployed, let me know how it works for you! :)

from flus.