Giter Club home page Giter Club logo

Comments (6)

Flupp avatar Flupp commented on September 27, 2024

I am not sure if I get your point. Do you refer to the unreleased commits v1.0...a65c31e on master? These commits are pure code cleanup and should not affect the user. In my opinion they do not really justify a new release.

from sticky-window-snapping.

tcanabrava avatar tcanabrava commented on September 27, 2024

That's true in theory, but theory never follows reality :)

A bit more background, I work together with @zzag and I realized the "sticky window snapping" that I use daily was not working. I verified that I have the latest version installed from the "get new stuff" so I start to debug what's happening.
New code entered on kwin and that changed how the javascript is read, zzag added code to fix that in 2019, but there's no release with that code yet:

This is what you get with the latest release:
kwin/scripts/sticky-window-snapping/contents/code/main.js:320: TypeError: Type error
kwin/scripts/sticky-window-snapping/contents/code/main.js:36: error: enabledCurrently is not defined

and the script doesn't work.

from sticky-window-snapping.

zzag avatar zzag commented on September 27, 2024

291bf5e is not simply a code cleanup. :) It ensures that the script will work with a js engine that properly supports strict mode. QtScriptEngine didn't have proper strict mode checks.

from sticky-window-snapping.

Flupp avatar Flupp commented on September 27, 2024

Thanks for the heads-up. I’ve finally managed to publish a new release. Turns out, KWin 5.22 introduced also some other subtle changes to the JavaScript API that needed fixing in the script.

from sticky-window-snapping.

ohyrans avatar ohyrans commented on September 27, 2024

Don't want to open a seperate issue just yet - but is trying to figure out why it doesn't work on my system (Opensuse TW, Plasma 5.22.2, Framework 5.83, Wayland + Intel) and not certain its related to Sticky Window Snapping, but something else - hence commenting here...
Tried reinstalling it, enabling/reenabling, reboot etc.

Is there a good way to get proper info about what may be going wrong to provide a better bug report?

from sticky-window-snapping.

Flupp avatar Flupp commented on September 27, 2024

@ohyrans: I created the new issue #15 and replied to you there. Please continue the discussion in the new issue.

from sticky-window-snapping.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.