Giter Club home page Giter Club logo

Comments (36)

kenhys avatar kenhys commented on August 10, 2024

centos8.with-rpmlint-i.utf8.log

from fluent-package-builder.

kenhys avatar kenhys commented on August 10, 2024

Fixed license #69

from fluent-package-builder.

kenhys avatar kenhys commented on August 10, 2024

extract from log to remark.

td-agent-debuginfo.x86_64: W: invalid-license
td-agent-debugsource.x86_64: W: hidden-file-or-dir
td-agent-debugsource.x86_64: W: invalid-license
td-agent-debugsource.x86_64: W: no-documentation
td-agent.x86_64: E: binary-or-shlib-defines-rpath
td-agent.x86_64: E: dir-or-file-in-opt
td-agent.x86_64: E: dir-or-file-in-var-run
td-agent.x86_64: E: incoherent-logrotate-file
td-agent.x86_64: E: incorrect-fsf-address
td-agent.x86_64: E: missing-call-to-chdir-with-chroot
td-agent.x86_64: E: non-executable-script
td-agent.x86_64: E: non-standard-executable-perm
td-agent.x86_64: E: rpath-in-buildconfig
td-agent.x86_64: E: script-without-shebang
td-agent.x86_64: E: wrong-script-interpreter
td-agent.x86_64: E: zero-length
td-agent.x86_64: W: crypto-policy-non-compliance-openssl
td-agent.x86_64: W: dangling-relative-symlink
td-agent.x86_64: W: devel-file-in-non-devel-package
td-agent.x86_64: W: executable-stack
td-agent.x86_64: W: hidden-file-or-dir
td-agent.x86_64: W: invalid-license
td-agent.x86_64: W: manpage-not-compressed
td-agent.x86_64: W: name-repeated-in-summary
td-agent.x86_64: W: no-documentation
td-agent.x86_64: W: no-manual-page-for-binary
td-agent.x86_64: W: no-soname
td-agent.x86_64: W: non-conffile-in-etc
td-agent.x86_64: W: pem-certificate
td-agent.x86_64: W: read-error
td-agent.x86_64: W: spurious-executable-perm
td-agent.x86_64: W: summary-ended-with-dot
td-agent.x86_64: W: uncompressed-zip

from fluent-package-builder.

kenhys avatar kenhys commented on August 10, 2024

td-agent.x86_64: W: invalid-license

fixed via #69

from fluent-package-builder.

kenhys avatar kenhys commented on August 10, 2024

put /etc/rpmlint/config and addFilter for td-agent.x86_64: E: dir-or-file-in-opt.

from fluent-package-builder.

kenhys avatar kenhys commented on August 10, 2024

rebased and tried to fix E: dir-or-file-in-opt. #67

from fluent-package-builder.

kenhys avatar kenhys commented on August 10, 2024

It should feedback to upstream
td-agent.x86_64: E: incorrect-fsf-address

from fluent-package-builder.

kenhys avatar kenhys commented on August 10, 2024

td-agent.x86_64: E: incorrect-fsf-address

Should be fixed in upstream, so I've send PR
https://github.com/libffi/libffi/pll/564

from fluent-package-builder.

kenhys avatar kenhys commented on August 10, 2024

td-agent.x86_64: E: incorrect-fsf-address

fixed via 852e573

from fluent-package-builder.

kenhys avatar kenhys commented on August 10, 2024

td-agent.x86_64: E: missing-call-to-chdir-with-chroot

It should be fixed in ruby(upstream).

from fluent-package-builder.

kenhys avatar kenhys commented on August 10, 2024

td-agent.x86_64: E: non-executable-script

It seems that these are false positive case.

from fluent-package-builder.

kenhys avatar kenhys commented on August 10, 2024

E: non-standard-executable-perm

It should be fixed in upstream(digest-crc)

from fluent-package-builder.

kenhys avatar kenhys commented on August 10, 2024

E: script-without-shebang

It seems that these are false positive case.

from fluent-package-builder.

kenhys avatar kenhys commented on August 10, 2024

E: wrong-script-interpreter

It seems that these are false positive case, too.

from fluent-package-builder.

kenhys avatar kenhys commented on August 10, 2024

td-agent.x86_64: E: zero-length

I've fixed some extent via #75

from fluent-package-builder.

kenhys avatar kenhys commented on August 10, 2024

W: pem-certificate

Use addFilter("W: pem-certificate")

from fluent-package-builder.

kenhys avatar kenhys commented on August 10, 2024

TODO:

% cat 20200603.0845.filter.log | awk '{print $1,$2,$3}' | sort|uniq
td-agent-debugsource.x86_64: W: hidden-file-or-dir
td-agent-debugsource.x86_64: W: no-documentation
td-agent.x86_64: E: binary-or-shlib-defines-rpath
td-agent.x86_64: E: dir-or-file-in-var-run
td-agent.x86_64: E: incoherent-logrotate-file
td-agent.x86_64: E: non-standard-executable-perm
td-agent.x86_64: E: rpath-in-buildconfig
td-agent.x86_64: E: zero-length
td-agent.x86_64: W: dangling-relative-symlink
td-agent.x86_64: W: devel-file-in-non-devel-package
td-agent.x86_64: W: executable-stack
td-agent.x86_64: W: hidden-file-or-dir
td-agent.x86_64: W: manpage-not-compressed
td-agent.x86_64: W: no-documentation
td-agent.x86_64: W: no-manual-page-for-binary
td-agent.x86_64: W: no-soname
td-agent.x86_64: W: non-conffile-in-etc
td-agent.x86_64: W: read-error
td-agent.x86_64: W: spurious-executable-perm

W: hidden-file-or-dir will be fixed in #76

from fluent-package-builder.

kenhys avatar kenhys commented on August 10, 2024

td-agent.x86_64: W: devel-file-in-non-devel-package

Fixed via 26ae9cc

from fluent-package-builder.

kenhys avatar kenhys commented on August 10, 2024

td-agent.x86_64: E: zero-length

It seems that it is added for bakefile
https://github.com/socketry/async-http/blob/master/bake.rb

from fluent-package-builder.

kenhys avatar kenhys commented on August 10, 2024

td-agent.x86_64: E: zero-length

Fixed via 74472fc

from fluent-package-builder.

kenhys avatar kenhys commented on August 10, 2024

E: incoherent-logrotate-fil

It should be /etc/logrotate.d/td-agent.

from fluent-package-builder.

kenhys avatar kenhys commented on August 10, 2024

E: binary-or-shlib-defines-rpath

use --disable-rpath for it.

from fluent-package-builder.

kenhys avatar kenhys commented on August 10, 2024

td-agent.x86_64: W: executable-stack

Fixed via 3ff5f9f

from fluent-package-builder.

kenhys avatar kenhys commented on August 10, 2024

E: rpath-in-buildconfig

Fixed via
34fabec

from fluent-package-builder.

kenhys avatar kenhys commented on August 10, 2024

W: spurious-executable-perm

This will be solved if #76 is merged.

from fluent-package-builder.

kenhys avatar kenhys commented on August 10, 2024

td-agent.x86_64: W: spurious-executable-perm

Fixed via
#92

from fluent-package-builder.

kenhys avatar kenhys commented on August 10, 2024

Oops, dangling symlink exists...

$ pwd
/opt/td-agent/lib/ruby/gems/2.4.0/gems/ffi-1.13.1/ext/ffi_c/libffi-x86_64-linux/.libs
[vagrant@localhost .libs]$ ls -la
total 156
drwxr-xr-x. 3 root root  4096 Jun 10 05:54 .
drwxr-xr-x. 8 root root  4096 Jun 10 05:54 ..
lrwxrwxrwx. 1 root root    12 Jun 10 05:54 libffi.la -> ../libffi.la
-rw-r--r--. 1 root root   925 Jun 10 04:50 libffi.lai
lrwxrwxrwx. 1 root root    15 Jun 10 05:54 libffi.so -> libffi.so.8.1.0
lrwxrwxrwx. 1 root root    15 Jun 10 05:54 libffi.so.8 -> libffi.so.8.1.0
-rwxr-xr-x. 1 root root 56672 Jun 10 04:51 libffi.so.8.1.0
-rw-r--r--. 1 root root 83022 Jun 10 04:51 libffi_convenience.a
drwxr-xr-x. 2 root root  4096 Jun 10 04:50 libffi_convenience.a(D)
lrwxrwxrwx. 1 root root    24 Jun 10 05:54 libffi_convenience.la -> ../libffi_convenience.la

from fluent-package-builder.

kenhys avatar kenhys commented on August 10, 2024

It should be removed, but not. logged by:

rm -rf test spec
rm -f ext/ffi_c/libffi-x86_64-linux/a.out
rm -f ext/ffi_c/LongDouble.o ext/ffi_c/MappedType.o ext/ffi_c/Thread.o ext/ffi_c/Call.o ext/ffi_c/Types.o ext/ffi_c/Variadic.o ext/ffi_c/MemoryPointer.o ext/ffi_c/ffi.o ext/ffi_c/StructLayout.o ext/ffi_c/StructByValue.o ext/ffi_c/LastError.o ext/ffi_c/FunctionInfo.o ext/ffi_c/Function.o ext/ffi_c/ArrayType.o ext/ffi_c/MethodHandle.o ext/ffi_c/Type.o ext/ffi_c/Pointer.o ext/ffi_c/Buffer.o ext/ffi_c/DynamicLibrary.o ext/ffi_c/AbstractMemory.o ext/ffi_c/Platform.o ext/ffi_c/ClosurePool.o ext/ffi_c/Struct.o ext/ffi_c/libffi-x86_64-linux/libffi.la ext/ffi_c/libffi-x86_64-linux/libffi_convenience.la
cd -

from fluent-package-builder.

kenhys avatar kenhys commented on August 10, 2024

Confirmed that after remove_files("ext/**/*.{la}"), Dir.glog(pattern) is empty.

from fluent-package-builder.

kenhys avatar kenhys commented on August 10, 2024

Confirmed that after remove_file("ext/**/*.{la}"), find -type f finds them:

-rw-r--r-- 1 root root     925 Jun 12 00:43 ./ext/ffi_c/libffi-x86_64-linux/.libs/libffi.lai
snip
-rw-r--r-- 1 root root     894 Jun 12 00:43 ./ext/ffi_c/libffi-x86_64-linux/libffi_convenience.la

from fluent-package-builder.

kenhys avatar kenhys commented on August 10, 2024

Reproduced: This issue is caused by .libs/

from fluent-package-builder.

kenhys avatar kenhys commented on August 10, 2024
mkdir -p ext/libs
mkdir -p ext/.libs
touch ext/libs/fuga ext/.libs/fuga

Then, execute:

require "fileutils"

Dir.glob("ext/**/fuga") do |file|
  p "REMOVE: <#{file}>"
  FileUtils.rm_rf(file)
end
puts `find ext -type f | xargs ls -la`

Actual result:

% ruby test_rm_rf.rb
"REMOVE: <ext/libs/fuga>"
-rw-r--r-- 1 kenhys docker 0  6月 12 09:55 ext/.libs/fuga

Still fuga is exists.

from fluent-package-builder.

kenhys avatar kenhys commented on August 10, 2024

td-agent.x86_64: W: dangling-relative-symlink
td-agent.x86_64: W: read-error

Fixed via #99

from fluent-package-builder.

kenhys avatar kenhys commented on August 10, 2024

W: only-non-binary-in-usr-lib

I've fixed via #107

from fluent-package-builder.

kenhys avatar kenhys commented on August 10, 2024

W: incoherent-subsys

Fixed via #108

from fluent-package-builder.

kenhys avatar kenhys commented on August 10, 2024

most of issues were fixed now!

from fluent-package-builder.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.