Comments (5)
Hi @shinji62,
Thank you for your reporting and investigating. I talk about it with other collaborators. So, please wait.
Thanks,
Muga
from fluent-logger-java.
Thanks for the report. We want to reproduce the connection leak. Could you let me know the followings?
- How many did you create Loggers? In other words, How often did you change the arguments for FluentLogger.getLogger()?
- How many did those connections remain? What was the connection status ("established", "close_wait" or etc.)?
- Did you use multiple FluentLoggerFactory?
from fluent-logger-java.
We wrap the FluentLogger in a logback appender like the following:
doAppend(stuffToLog) {
FluentLogger logger = FluentLogger.getLogger("sametag", "samehost", "sameport")
logger.log(stuffToLog)
}
So getLogger gets called everytime with the same arguments on each log call.
In our runs, we see an increased connections in CONNECTION_ESTABLISHED state.
In our app constantly receiving traffic, it just continues increasing until you
hit system memory limits.
from fluent-logger-java.
I couldn't reproduce this connection leak issue with logback AppenderBase class and concurrently making alot of GC.
Regarding the code, FluentLogger calls RawSocketSender#close() in its finalize(). So it looks that FluentLogger closes the TCP connection even if it's released from the WeakHashMap.
One question. Did you use the logger in multi-threaded environment?
Also, can you create minimal code which can reproduce this issue? If you can, it's very helpful for fixing the issue.
Thanks
from fluent-logger-java.
I know it has some time, but maybe it can help others.
Could it happen because logger.close()
is never called?
doAppend(stuffToLog) {
FluentLogger logger = null;
try{
logger = FluentLogger.getLogger("sametag", "samehost", "sameport")
logger.log(stuffToLog)
} catch(...){
...
} finally{
if(logger != null)
logger.close();
}
}
from fluent-logger-java.
Related Issues (20)
- Bad thread interleaving may cause unexpected crash
- Current Error Handling does not return false on logging errors HOT 3
- NullPointerException when the Fluentd server is down
- API changes report for Fluent Logger HOT 1
- support fluentd with secure_forward HOT 1
- java.net.SocketException: Broken pipe HOT 4
- FluentLoggerFactory not invalidate cache after FluentLogger close
- Calling `.close()` does not clean up instance in `FluentLoggerFactory` HOT 2
- NPE in RawSocketSender HOT 1
- There is no way to set socket read timeout HOT 1
- Conflict with Spring cloud SpringApplication run
- Release 0.3.4? HOT 2
- Connection Reset on calling Fluentlogger.log() HOT 3
- Conflict with Spring Webflux
- How to pass credentials to connect remote fluentD aggregator HOT 1
- Null Pointer Exception with slf4j-log4j12-1.7.30 (Fluent-logger incompatible with the new version) HOT 3
- is this libarary can be used for fluent-bit? HOT 1
- log4j JNDI vulnerability HOT 4
- Add Support For Unix Domain Sockets HOT 1
- Is this library still maintained?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fluent-logger-java.