Increased connections to the in_forward plugin server about fluent-logger-java HOT 5 OPEN

Hi @shinji62,

Thank you for your reporting and investigating. I talk about it with other collaborators. So, please wait.

Thanks,
Muga

from fluent-logger-java.

@shinji62 ,

Thanks for the report. We want to reproduce the connection leak. Could you let me know the followings?

1. How many did you create Loggers? In other words, How often did you change the arguments for FluentLogger.getLogger()?
2. How many did those connections remain? What was the connection status ("established", "close_wait" or etc.)?
3. Did you use multiple FluentLoggerFactory?

from fluent-logger-java.

We wrap the FluentLogger in a logback appender like the following:

doAppend(stuffToLog) {
  FluentLogger logger = FluentLogger.getLogger("sametag", "samehost", "sameport") 

  logger.log(stuffToLog)
}

So getLogger gets called everytime with the same arguments on each log call.

In our runs, we see an increased connections in CONNECTION_ESTABLISHED state.
In our app constantly receiving traffic, it just continues increasing until you
hit system memory limits.

from fluent-logger-java.

I couldn't reproduce this connection leak issue with logback AppenderBase class and concurrently making alot of GC.

Regarding the code, FluentLogger calls RawSocketSender#close() in its finalize(). So it looks that FluentLogger closes the TCP connection even if it's released from the WeakHashMap.

One question. Did you use the logger in multi-threaded environment?

Also, can you create minimal code which can reproduce this issue? If you can, it's very helpful for fixing the issue.

Thanks

from fluent-logger-java.

I know it has some time, but maybe it can help others.
Could it happen because logger.close()is never called?

doAppend(stuffToLog) {
  FluentLogger logger = null; 
  try{
      logger = FluentLogger.getLogger("sametag", "samehost", "sameport")
      logger.log(stuffToLog)
  } catch(...){
      ...
  } finally{
     if(logger != null)
         logger.close();
  }
}

from fluent-logger-java.