Giter Club home page Giter Club logo

Comments (4)

tommedema avatar tommedema commented on July 17, 2024

I confirmed that this is in fact caused by recent changes by checking out to commit f62a558 - this is without the streaming changes. At this commit, everything worked fine again.

There must be something wrong with passing in streams like this. Maybe there are issues related to piping. In that case, we should manually pipe the input stream to ffmpeg's stdin stream.

from node-fluent-ffmpeg.

tommedema avatar tommedema commented on July 17, 2024

fixed in #16, tested too.

from node-fluent-ffmpeg.

schaermu avatar schaermu commented on July 17, 2024

i'll re-add the old streaming code by adding an option to switch between the piping (customFds) and the pumping (stream.pump()) mode (sounds awkward i know ;))

from node-fluent-ffmpeg.

tommedema avatar tommedema commented on July 17, 2024

@schaermu, ehh that sounds highly illogical - why would you ever want to do that?

The fix I provided is the best of both worlds. Just passing in Fds is not possible because the write buffer will get full, apparently, this is why we had to use piping.

from node-fluent-ffmpeg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.