Giter Club home page Giter Club logo

Comments (2)

schaermu avatar schaermu commented on August 16, 2024

thanks for mentioning the typo, forgot to run unit tests before last commit sigh.

Considering your other points:

  1. does that mean i have to set --adjustment to something like '+10' for a niceness of 10?
  2. i'm using a different method for executing ffmpeg in thumbnail generation to make sure the supplied taskcallback is called correctly (it is feeded directly to the exec() call). i already tried it with spawn, it did never work properly.

spawn() in nodejs creates a process in a sync way, you dont have to wait for a callback. The process' pid is available directly after calling spawn(), thus it's 'reniceable'.

I'll be looking into a more genereic way to prevent failure on windows systems (there are already multiple actions that break execution on windows, i.e. 'which' calls), see issue #13.

from node-fluent-ffmpeg.

tommedema avatar tommedema commented on August 16, 2024
  1. Actually, now that I think about it, the implementation would only be different for a process that has a different niceness than the default of 0. See http://manpages.ubuntu.com/manpages/jaunty/man1/nice.1.html - since you spawn the process yourself, this default will always be 0 so it should not be a problem.
  2. Alright, strange that it does not work with spawn, I guess this is fine though.

Closing issue

from node-fluent-ffmpeg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.