Comments (3)
vamche
commented on May 18, 2024
1
@floydspace Thanks for testing. I have tested on my side, I confirm that it's working with npm6. The issue is with npm7 only because of the change in output of npm ls -prod -json.
As you suggested, I will try to find a way which is backward compatible.
from serverless-esbuild.
floydspace
commented on May 18, 2024
Hi @vamche thanks for the new issue, I checked out your branch and ran npx sls package (it prepares final artifacts)
And I see that everything is packaged as you expect.
so I couldn't reproduce on my node14, npm6 environment
Could you provide details about your environment? I suppose you're using npm7, maybe this causes the issue?
from serverless-esbuild.
floydspace
commented on May 18, 2024
Indeed I checked in node16, npm7 environment and it behaves as you described. I would appreciate if you make a fix, but keep in mind compatibility with older environments. Blindly passing depth 5 could break npm6, so you have to find the way it's working in both envs or implemented special case for npm7 as you described. thank you
from serverless-esbuild.
Related Issues (20)
- Bun support HOT 1
- Unable to serverless package when no lambdas exist HOT 3
- serverless deploy fails without a reason when using esbuild-plugin-tsc HOT 2
- Rewrite Module Packaging Logic HOT 3
- I'm not sure if it supports layers
- pnpm: external modules bundled without their nested modules. HOT 2
- Indirect dependency marked as external missing in package HOT 1
- Slow performance when using external property
- Esbuild cannot rebuild error
- `patterns` not respected at `invoke local`
- sls package fails with individually: true for specific function Error: ENOENT: no such file or directory, copyfile
- update esbuild peerDependency HOT 1
- Support ESBuild 0.20.0 HOT 2
- watch function work with serverless-localstack.
- Possible memory-use regression in v1.48.1 HOT 1
- Stuck on Need a faster logging experience when using serverless-stack with serverless-esbuild HOT 1
- Support Lambda custom runtimes HOT 2
- Trouble importing to esbuild.config.js from an internal monorepo package HOT 1
- Hangs indefinitely on esbuild error HOT 1
- Overriding the keyword used to get the handler in the lambda function defintion HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from serverless-esbuild.