Include node_modules when externals are populated via plugins (for eg., esbuild-node-externals) about serverless-esbuild HOT 3 CLOSED

Hi @vamche , thank you for the issue and the example. I cloned your repo and indeed the esbuild-node-externals plugin is excluding your dependencies from the bundle, but serverless-esbuild assumes that they are bundled.

I think it makes sense to implement a special case with the plugin, so if it is used we just get the list of modules determined by the plugin and put them to external to have packed.

If you really like to contribute, here is the direction: the plugin has exported function findDependencies you can reuse it to build a list of dependencies to be packed, and then the list must be used in our packExternalModules function which does the job. Should be an easy fix. Thank you 🙏

from serverless-esbuild.

FYI, serverless-webpack does this with includeModules config and webpack-node-externals plugin.

I am happy to help/contribute to code if this feature can be introduced (if not already available). I would need some direction though. :)

from serverless-esbuild.

Thank you @floydspace, I will give it a shot.

from serverless-esbuild.