Data race in `pongo2.FromFile()` method about pongo2 HOT 5 OPEN

If it's about the line

	set.firstTemplateCreated = true

Then it's harmless, it's just unprotected access on a basically integer value, which on x86/x64 will "just" result in different CPUs seeing a different cached value until they are synced (which is usually unpredictable).

The easiest fix would be to either convert firstTemplateCreated to int32 and use StoreInt32 or LoadInt32 from sync/atomic, or convert it to the Bool type from the same module.

See e.g. https://pkg.go.dev/sync/atomic#Bool

from pongo2.

This might be related to #163

from pongo2.

My temporary solution is to use sync.Mutex in the method where pongo2.FromFile() is called:

var renderMu sync.Mutex
func RenderView() {
    renderMu.Lock()
    defer renderMu.Unlock()
    
    tmpl, err := pongo2.FromFile("index.html")
    // .... rest of the code
}

from pongo2.

Thanks for reporting, will have a look when time allows.

from pongo2.

I can confirm the issue is fixed by changing set.firstTemplateCreated to an atomic boolean type.

from pongo2.