Comments (5)
The Part where i set
// this line below
$image = $this->overlay($image, $options);
seems to break some things, even though the overlay method exists
from kirby-focus.
I'm not sure if I could follow all of your explanations, but I think I got it
In GdLib.php
of the Focus plugin you have this code (please see the comment inside):
public function process(string $file, array $options = []): array
{
$options = $this->preprocess($file, $options);
$originalImage = new Image($file);
if ($dimensions = $originalImage->dimensions()) {
$options['originalWidth'] = $dimensions->width();
$options['originalHeight'] = $dimensions->height();
}
$image = new SimpleImage();
$image->fromFile($file);
$image = $this->autoOrient($image, $options);
$image = $this->resize($image, $options);
$image = $this->blur($image, $options);
$image = $this->grayscale($image, $options);
// you added this line, right?
$image = $this->overlay($image, $options);
$image->toFile($file, null, $options['quality']);
return $options;
}
I think the methods autoOrient()
, resize()
, blur()
and grayscale()
(which are listed below in the file) are just helper methods for the SimpleImage class.
The method you added and the end of the file also refers to SimpleImage
and I think the code breaks, because there's no overlay()
method in the SimpleImage
class.
// you added this new method?!
protected function overlay(SimpleImage $image, array $options)
{
if($options['overlay'] === false){
return $image;
}
// this refers to the SimpleImage class, I think …
return $image->overlay(kirby()->root('assets').'/watermark.png','center',1,0,0);
}
Unfortunately I'm not sure if I can help you with this …
from kirby-focus.
is there not?
from kirby-focus.
from kirby-focus.
I close the issue because it is not related to the functionality of the plugin. Sorry, that I couldn't help you with your question.
from kirby-focus.
Related Issues (20)
- Images not cropped on PHP 7.3 or 7.4 HOT 11
- Bug: Breaks when media-Folder is at another place HOT 4
- Question regarding 'components.thumb' HOT 2
- kirby3-colorist supports 'Focus' HOT 4
- Does not create cropped images on server HOT 5
- Update focus field on `file.replace` HOT 4
- Transparent PNG Problem HOT 1
- Does not play nice with `translate: false` HOT 1
- WebP Support HOT 12
- [Question] Is the support for Kirby Block previews planned HOT 1
- focusSrcset does not update URL on focus point changes HOT 11
- New Kirby 3.6 Feature to support multiple mime-types is not working with this plugin for GD. HOT 3
- WebP and AVIF generated images put into wrong folder in v3.0.8 HOT 26
- Kirby 3.5.x not supported in v3.0.8 HOT 7
- [Question] multiple focus fields HOT 2
- CSS not being loaded HOT 2
- Reset focuspoint HOT 1
- Optional color fading ? HOT 2
- Preview missing for svg HOT 2
- value without effect for foxi HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kirby-focus.