Move Darkroom type definition out of global scope about kirby-focus HOT 8 CLOSED

They are two properties in the Darkroom class. Whenever you call the Darkroom::factory it will return what is set in those properties. The only important thing is that you set your properties before you call Darkroom::factory.
You are not doing that manually in your plugin, but it is called in the thumbs method. If you insert the property definition somewhere before you return $this->thumb() you will be fine.

from kirby-focus.

You are right, it does not work as I suggested. I don't quite understand why....
Unfortunately are thumbs components overwriting each other. The last one declared will be the one used.

We could at least make our two plugins work together:

• You omit using the thumbs component.
• You declare your Darkroom::$types globally (as before).
• I reset the Darkroom::$types after cliping in my plugin.

But that does not save you from other plugins messing with Darkroom::$types, I don't see a good solution for this problem.

from kirby-focus.

I posted a possible solution in the ideas repo. please upvote! getkirby/ideas#278

from kirby-focus.

Thanks for your suggestion.

I thought it must be in global scope to replace the default Darkroom class. I will test it and fix it, if I find a better way …

from kirby-focus.

Thanks for your help … very much appreciated!

from kirby-focus.

I tried to implement your suggestion. Unfortunately, it doesn't work to set the Darkroom type definition inside the custom focusCrop file method.

However, it does work when I declare a custom thumb component as you do like this …

But as far as I can see, this will lead to conflicts with other custom thumb components because only one will finally be used by Kirby, right?

from kirby-focus.

I just understood why...
focusCrop is called on a Kirby instance, then file::version and the job file is generated (the thumbs component is never called here).
To actually generate the thumb, it is a new request to the server (the image url), a new Kirby instance, which does never go via focusCrop but directly to the thumbs component.

from kirby-focus.

Ok, I got it. Thanks for taking the time and for this explanation.

from kirby-focus.