Giter Club home page Giter Club logo

Comments (5)

flokosiol avatar flokosiol commented on May 28, 2024

Thanks for your feedback.

Could you please have a look at the generated image filenames in your media folder? They should include the x and y coordinates.

from kirby-focus.

gerricom avatar gerricom commented on May 28, 2024

Unfortunately not. It looks only like my-wonderful-image-1200x400-q90.jpg

from kirby-focus.

flokosiol avatar flokosiol commented on May 28, 2024

Unfortunately I have no access to my computer at the moment, so it‘s not possible for me to have a closer look at this. But for now, let’s check the code which is responsible for the creation of the filename.

Here the coordinates are added to the thumb options:
https://github.com/flokosiol/kirby-focus/blob/k-next/config.php#L76

And this is the Filename crop() method in Kirby which adds it to the filename. It changed with the latest beta. In older versions it was not possible to pass custom crop positions to the method.
https://github.com/k-next/kirby/blob/master/src/Cms/Filename.php#L177

Could you please verify that your code is up to date?

… and just for the record, I‘m pretty sure you are using focusCrop() in your template, right?

I will have a closer look at this next week.

from kirby-focus.

gerricom avatar gerricom commented on May 28, 2024

Okay - I'm very sorry. It seems, I mixed up the nightly builds and the latest beta. I fetched the latest beta and suddenly, all is good. Sorry!

from kirby-focus.

flokosiol avatar flokosiol commented on May 28, 2024

No problem at all. Glad, that it works now.

from kirby-focus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.