Feature flag not being enabled in RSpec specs on 1.2.1 about flipper HOT 7 CLOSED

@norman Sorry you're running into issues. TestHelp was just added in 1.2 and is enabled by default. I'm guessing there's an order issue with the before/around callbacks.

To help isolate it, can you first try disabling the TestHelp integration?

# config/initializers/flipper.rb
Rails.application.configure do
  config.flipper.test_help = false
end

If your test pass after that, then I'm guessing what is happening is:

1. Your with_feature_flag helper enables the feature in the around block
2. TestHelp#flipper_configure gets called, resetting the current flipper instance
3. The specs run with the newly configured flipper instance

from flipper.

Sorry you're running into issues.

@bkeepers No worries! Thanks for the quick response and thanks for working on this library that my coworkers and I are super happy with.

To help isolate it, can you first try disabling the TestHelp integration?

Yes, the specs pass when I add the initializer you provided.

I think our usage of adding a context-level around hook is pretty weird, a fair solution to the problem might just be to document that as "DON'T DO THIS" - I can change our code to call the with_feature_flag in a before block, which should be compatible with your code as-is. Getting your setup code to reliably run before my around hook seems difficult with RSpec.

from flipper.

@norman can you try this branch with your original with_feature_flag helper?

gem 'flipper-active_record', git: 'https://github.com/flippercloud/flipper', branch: 'rspec-prepend'

from flipper.

@norman can you try this branch with your original with_feature_flag helper?

gem 'flipper-active_record', git: 'https://github.com/flippercloud/flipper', branch: 'rspec-prepend'

Yes! That worked.

from flipper.

Yes! That worked.

Awesome. And just to confirm, this is with config.flipper.test_help = true?

from flipper.

Yes! That worked.

Awesome. And just to confirm, this is with config.flipper.test_help = true?

Oh crap. Sorry, I'm doing a million things at once right now and forgot to unset that. I still had your initializer running. When I removed it the specs no longer pass with your branch, the behavior is the same as my original report.

from flipper.

Howdy 👋🏻 🤠
FWIW Jumping in here to say I'm experiencing a similar issue in a Rails(7.0.8) app albeit we use Redis instead of ActiveRecord for Flipper. We are using RSpec v3.12 with Flipper.enable/disable in our tests. These tests were passing before this update.

The config changes in the Flipper initializer mentioned earlier in this thread allowed our Flipper-related tests to pass 🤩 , but the rspec-prepend gem branch did not. I was guessing at the gem though:

gem 'flipper-redis', git: 'https://github.com/flippercloud/flipper', branch: 'rspec-prepend'

I could be wrong there ☝🏻
LMK if you have other questions 🙏🏻

from flipper.