DataBuilderClassInfo - customize Builder Name about databuilderframework HOT 5 CLOSED

String name based customization is already provided by DataBuilderInfo.

The usecases for these are as follows:

1. DatabuilderInfo -> use where components are loaded dynamically at runtime.
2. DataBuilderClassInfo -> Used primarily as a library, for type safety.

Do you see other usecases?

from databuilderframework.

DataBuilderClassInfo enforces builder names in data attribute to to be Canonical name when serialized.. This is right as it prevents namespace collision. But it makes the whole data label verbose and hard to read.

In one of my use cases, I wanted to use class.Simplename() as my builder where named differently without any namespace collisions as this improved readability in JSON string of the DataflowInstance.
I agree this can be done done with DatabuilderInfo but felt that using DataBuilderClassInfo shouldn't restrict the naming logic derived from the class Object.

from databuilderframework.

enforcing this should be optional and will lead to collisions of name in
large(ish) projects. You can go ahead with this change under a flag, but in
general this should not be encouraged as it compromises (namespace) safety.

Upset the established order, and everything becomes chaos. I'm an agent of
chaos. Oh and you know the thing about chaos, it's fair.

On Wed, Oct 14, 2015 at 11:51 AM, gokulvanan [email protected]
wrote:

DataBuilderClassInfo enforces builder names in data attribute to to be
Canonical name when serialized.. This is right as it prevents namespace
collision. But it makes the whole data label verbose and hard to read.

In one of my use cases, I wanted to use class.Simplename() as my builder
where named differently without any namespace collisions as this improved
readability in JSON string of the DataflowInstance.
I agree this can be done done with DatabuilderInfo but felt that using
DataBuilderClassInfo shouldn't restrict the naming logic derived from the
class Object.

—
Reply to this email directly or view it on GitHub
#12 (comment)
.

from databuilderframework.

agreed.. will keep this as optional parameter in an overloaded method to inject an optional NameResolver implementation along with registering @DataBuilderClassInfo annotation.

from databuilderframework.

Reopen if you ever decide to send a patch.

from databuilderframework.