Giter Club home page Giter Club logo

Comments (3)

fredrik-johansson avatar fredrik-johansson commented on June 3, 2024

Hopefully fixed in 4161094. Not tested on a 32-bit system, but it was easy enough to produce a similar failure on 64-bit by tweaking the test parameters.

The underlying problem is that a division by zero sometimes only sets the real part or the imaginary part of an acb_t to [nan +/- inf]. This is fine with the understanding that the imaginary part alone is meaningless when the real part contains nan (and vice versa).

However, acb_overlaps() and acb_contains() compare the real and imaginary parts separately without taking this into account, so using them to test identities can give spurious failures.

Propagation and detection of non-finite real and imaginary parts should probably be made more aggressive, to improve overall robustness. But for the time being, I'm content with putting in an extra finiteness check in any test function where this kind of failure occurs.

When examining this bug, I noticed that the recurrence relation tested in t-laguerre_l actually is inconsistent with the implemented definition of the function when n is a negative integer, and this leads to further spurious test failures. I don't know which definition is more useful (this is one of those cases where Mathematica contradicts itself and thus cannot be used as a reference), so I've just changed the function implementation to make this case indeterminate.

from arb.

fredrik-johansson avatar fredrik-johansson commented on June 3, 2024

Tests pass for me on a 32-bit Linux virtual machine.

I've issued 2.8.1 with the fix.

from arb.

jdemeyer avatar jdemeyer commented on June 3, 2024

Yes, this can be closed now.

from arb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.