json2dict converts unquoted true and false to numerical boolean about yajl-tcl HOT 6 CLOSED

That's an interesting observation. In general, we've tried to make the yajl::json2dict function perform identically to the same one provided by the json package, except faster. However, this is indeed an unintended difference in behavior:

package require json

::json::json2dict {{
"valueTrue": true,
"valueFalse": false
}}

valueTrue true valueFalse false

from yajl-tcl.

I think changing the replacements in parse2dict_boolean_callback might fix this behavior? https://github.com/flightaware/yajl-tcl/blob/master/generic/yajltcl.c#L227

from yajl-tcl.

Thanks @bovine for your response, I also have seen that location but I was not sure if there might be other side effects when fixing it. As there are already tests for the library, we can rerun the tests and see if something has been broken. I will recompile the library and check.

from yajl-tcl.

@bovine I have performed a pull request. Let's see the test results in the ci..

from yajl-tcl.

Can you please approve the waiting workflows (#39)? Thanks.

from yajl-tcl.

That PR has been merged and released as v1.8.1

from yajl-tcl.