Spawning temporary actors with [ExecuteInEditMode] about flaxapi HOT 5 CLOSED

Thanks for the report. I was able to reproduce it but the problem is that in OnDisable you don't clear the reference to a deleted object and it is left as an invalid reference (object is not null but it does not have a valid pointer to the underlying C++ object).

The proper fix for this would be changing OnDisable to:

Destroy(ref _container);

Or you can modify the OnEnable and use this check:

if (!_container) // <- implicit comparision operator that checks if object is not null and has valid C++ object reference
{
...

from flaxapi.

Can you send me a project on Discord? Because I tested with ref keyword and it worked well. Maybe my reproduction steps were different.

from flaxapi.

Ok I tested your project and I was able to see the issue.

The problem here is not related to the engine but more to the scene objects usage. Because your script always spawns the object in Start (if no reference is saved). So using this quick fix is actually a proper way of usage.

I was thinking about changing the play-mode enter logic from Serialize Scenes -> OnDisable -> Play to OnDisable -> Serializes Scenes -> Play but it would break some stuff and we don't want to modify it now.

To fix this you can also use Actor.HideFlags = HideFlags.DontSave which is a good choise for a temporary run-time only objects.

Or use Actor.GetOrAddChild to don't spawn actor if it's already there.

from flaxapi.

I changed Destroy(_container); to Destroy(ref _container);, however, an issue still persists.
If I repeatedly start and stop the game, it will spawn actors, but not remove them.

Here is what it looks like after hitting Play a few times.

from flaxapi.

@mafiesto4 Should I open a new issue or should this issue be re-opened?

from flaxapi.