Giter Club home page Giter Club logo

Comments (10)

bilelmoussaoui avatar bilelmoussaoui commented on June 18, 2024

It should be possible yes, not sure why you need to specify the working dir for it to work?

from flatpak-github-actions.

plata avatar plata commented on June 18, 2024

The problem is this: https://github.com/PhoenicisOrg/phoenicis/blob/8befcc028d1e1392f906959521d851c51e6f85b5/phoenicis-dist/src/flatpak/org.phoenicis.playonlinux.yml#L111

from flatpak-github-actions.

bilelmoussaoui avatar bilelmoussaoui commented on June 18, 2024

It should be just path: target/phoenicis-flatpak.zip ? also, why not build the java application inside the flatpak sandbox? because the application is built on cwd = the git repo we cloned.

from flatpak-github-actions.

plata avatar plata commented on June 18, 2024

It should be just path: target/phoenicis-flatpak.zip

Ok, I could change the path such that everything is relative to the project root dir. Currently, it's not like that because we have all our packaging in that submodule. So I would prefer to change the working directory.

why not build the java application inside the flatpak sandbox

Currently, you cannot build with Maven inside the flatpak. There's an open GitHub issue regarding this.

from flatpak-github-actions.

bilelmoussaoui avatar bilelmoussaoui commented on June 18, 2024

It should be just path: target/phoenicis-flatpak.zip

Ok, I could change the path such that everything is relative to the project root dir. Currently, it's not like that because we have all our packaging in that submodule. So I would prefer to change the working directory.

why not build the java application inside the flatpak sandbox

Currently, you cannot build with Maven inside the flatpak. There's an open GitHub issue regarding this.

You can use a simple buildsystem and add whatever commands you're using to build the .jar there, can't that work? at least for the CI, as you can have network access at build time if you want to :)

from flatpak-github-actions.

plata avatar plata commented on June 18, 2024

You can use a simple buildsystem and add whatever commands you're using to build the .jar there, can't that work?

As long as I'm outside the flatpak environment, yes.

from flatpak-github-actions.

bilelmoussaoui avatar bilelmoussaoui commented on June 18, 2024

You can use a simple buildsystem and add whatever commands you're using to build the .jar there, can't that work?

As long as I'm outside the flatpak environment, yes.

What are the differences?

from flatpak-github-actions.

plata avatar plata commented on June 18, 2024

see flatpak/flatpak-builder#58

from flatpak-github-actions.

bilelmoussaoui avatar bilelmoussaoui commented on June 18, 2024

Sure, I precisely mentioned using a "simple" buildsystem, which allows you to type whatever shell commands you want to execute. The maven build system support would allow you to set buildsystem to "maven" and flatpak-builder will figure out the rest for you.

from flatpak-github-actions.

plata avatar plata commented on June 18, 2024

I see. The project requires Maven, so I don't think that's a practical approach for me.

from flatpak-github-actions.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.