flask-restful disables the werkzeug debugger about flask-restful HOT 5 CLOSED

Hi, can you try with my patch at #9 to see if it solves your problem ?

Thanks.

from flask-restful.

Thanks for the work @gbin, it indeed solves the bug as I originally reported it and I think this pull request should go in.

However, I think it's worthwhile to note that I think the correct behaviour should be:

• error in API view with DEBUG=False: return error JSON
• error in non-API view with DEBUG=False: return the app's error page (customized or not)
• error in API view with DEBUG=True: return the werkzeug debugger; probably conditionally based on the Accept header in the request
• error in non-API view with DEBUG=True: return the werkzeug debugger

I think the correct way to achieve this lies in making flask-restful a blueprint (or a blueprint factory? not sure about flask terminology yet) and use this API to catch only blueprint related errors.

from flask-restful.

I gonna look at how we can improve the solution from the same applications running on the same instance.

I investigated the Blueprint in order to do that and it looks interesting.
The problem is that you cannot handle at this point the 404 and 500 errors from them.

from flask-restful.

Indeed a substantial issue. I think one could argue that for 404 and 500 all you need is the HTTP status, disregarding body, but this is bending the spec to what we can easily implement rather than the other way round. Maybe there's a better way - I'm just too new to Flask.

from flask-restful.

I think this pull request should be where the rest of this discussion take place, so I'm closing this commit. Sorry for the mess - wasn't sure how to create a pull request and attach it to an existing issue without fiddling with GitHub's API.

from flask-restful.