Giter Club home page Giter Club logo

Comments (5)

donmendelson avatar donmendelson commented on May 30, 2024

Note: this enhancement changes wire format and therefore is a breaking change with version 1.0.

from fix-simple-binary-encoding.

donmendelson avatar donmendelson commented on May 30, 2024

Related to issue #47 - both discuss composability of messages from common elements, using different terminology.

from fix-simple-binary-encoding.

donmendelson avatar donmendelson commented on May 30, 2024

This way if changes are made to a specific template such as metadata then the impact could be isolated to consumers of that section only

I'm in favor of improving message composibility, but I don't see how this proposal isolates changes. In SBE, versioning is atomic at the level of a message schema, not individual message templates. A change to either the container message or any submessage requires an updated schema anyway.

If a change to a submessage is a breaking change under the rules of schema extension, it would require a new template. In that case, the entire submessage would be unreadable to a client not on the current version.

from fix-simple-binary-encoding.

adkapur avatar adkapur commented on May 30, 2024

In SBE, versioning is atomic at the level of a message schema, not individual message templates. A change to either the container message or any submessage requires an updated schema anyway.

Yes correct but the outer message should rarely change for this to work and submessage changes will be of interest only to its interested consumers. Consumers not interested in that particular submessage can disregard it anyway

If a change to a submessage is a breaking change under the rules of schema extension, it would require a new template. In that case, the entire submessage would be unreadable to a client not on the current version.

Yes that is true only for a consumer interested in that particular submessage but if a consumer is not then it should be transparent to them

This proposal also included fields in the outer message which will contain the offset and template ID of each submessage allowing consumers to skip the submessage that they are not interested in and not having to decode that aside from reading the bytes

We are anyway thinking to drop this proposal since it requires double encoding in favor of the framing header wrapping around multiple templates and containing the total message length of the logical message (which could encompass multiple templates) and extending the SBE message header to include total message size

from fix-simple-binary-encoding.

RFrenkel avatar RFrenkel commented on May 30, 2024

yeay!

from fix-simple-binary-encoding.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.