Giter Club home page Giter Club logo

Comments (13)

samface avatar samface commented on June 25, 2024

+1 on this issue. One should atleast be able to disable the function that automatically adds hosts from the ssh config file.

from shuttle.

roxaloxa avatar roxaloxa commented on June 25, 2024

Agreed! Config file should just have a

"read_ssh_config": false

sort of deal. Would love this feature.

from shuttle.

binarykitchen avatar binarykitchen commented on June 25, 2024

No @roxaloxa that's a bad idea. I want the ssh config to be read. Just want to be able to ignore single entries in it. Better have something like ignore_in_shuttle (the ssh config file is not a JSON)

from shuttle.

roxaloxa avatar roxaloxa commented on June 25, 2024

@binarykitchen Oh okay, good point. For me, my only entry is a git server, so that's why I wanted the whole thing gone. But yours makes more sense.

from shuttle.

binarykitchen avatar binarykitchen commented on June 25, 2024

@roxaloxa Exactly. Peace :)

from shuttle.

samface avatar samface commented on June 25, 2024

@binarykitchen Why would it be a bad idea? Noone suggested that the feature would be to prevent anyone from having the ssh config file read, all I was suggesting was the OPTION to not to. I'd like that feature and I'd like it set to not automatically add anything from any of my personal configuration files by default. Forcing such things on people or assuming without asking that such things are up for grabs to be used for something entirely different than what was intended, now THAT is a bad idea.

For those of you who do want the ssh config file to be read and merged into your Shuttle configuration, you got your wish and I'm happy for you. I hope you don't mind me suggesting this feature to be turned off by default. The idea to enhance the ssh config reading feature with the option to filter out specific entries is a good one, but not a solution for everyone.

from shuttle.

binarykitchen avatar binarykitchen commented on June 25, 2024

@samface I understand. Sure, that's fine if there is an option for not adding anything from any personal config files. I have no reason to be against it. But I am not so sure to set a default for this one. Lots of my colleague hackers put dozens of servers in their config in .ssh/config ... so we should check first what the majority is.

Anyway, this one ticket of mine has the title Hide github.com from list. All I am asking here is for an option to ignore a single entry from .ssh/config and then I will shut up :)

from shuttle.

samface avatar samface commented on June 25, 2024

@binarykitchen I don't agree that it is an issue of what suits the majority the most. It's more like an issue of personal integrity for me. Like, the majority has facebook, but would that make it okay to automatically register everyone on facebook without asking first? I don't think so, just like I don't think it's ok when applications read my personal configuration files on my harddrive without asking me first.

from shuttle.

binarykitchen avatar binarykitchen commented on June 25, 2024

@samface I agree with you 200% on that Facebook example. But .ssh/config? That's a wide spread Unix standard. Bash shell scripts never ask you for accessing .ssh/config. You can ssh anything right away. It would deteriorate usability if it asked for access. Same goes with Shuttle I guess. Shuttle is not a sharing platform like FB and stays local. Hence I am not worried about Shuttle.

I think that's a decision up to the makers of Shuttle. Personal Integrity VS Usability. I was happy to see Shuttle is listing all my servers asap without any further hassle.

If integrity is still important for some, how about asking for access to .ssh/config during the installation process? Just an idea. That would be ok for me. Better than experimenting with Shuttle's config.

Anyway, we're off-topic again. This integrity discussion should go in a new ticket. Again, all I am asking for is a new option to ignore a single entry from .ssh/config, amen.

from shuttle.

samface avatar samface commented on June 25, 2024

It's a wide spread Unix standard to keep personal and private stuff in .ssh, such as SSH-keys, which domains you trust, etc. That should NEVER be anyone but the authorized logged in user to decide who and what gets access to. You talk like hidden directories in the personal home folder would be public domain or something.

from shuttle.

fitztrev avatar fitztrev commented on June 25, 2024

This has been merged. I'll write documentation and package a new release hopefully tomorrow.

In short, the following options will be available for accomplishing what has been discussed:

Disable all ~/.ssh/config entries:

"show_ssh_config_hosts": false,

Disable specific hosts:

"ssh_config_ignore_hosts": ["github.com", "git.example.com"],

Disable hosts that contain a keyword:

"ssh_config_ignore_keywords": ["git"],

Thank you to @mpdavis.

from shuttle.

binarykitchen avatar binarykitchen commented on June 25, 2024

Thanks so much!

from shuttle.

samface avatar samface commented on June 25, 2024

Awesome! Thank you! :)

from shuttle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.