Comments (3)
The function's comments are wrong - the weekday is running from 0=Monday to 6=Sunday.
The following gives the correct answer:
from convertdate import hebrew, gregorian, utils
shabbat = utils.next_weekday(5, hebrew.to_jd(5775,7,1))
gregorian.from_jd(shabbat)
(2014, 9, 27)
The underlying confusion comes from inconsistencies in Python - the time
and calendar
modules uses Monday=0, but datetime
uses Sunday=0.
For this project, I think sticking with the behavior of calendar
probably makes sense, since it's used internally for some conversions. Unless you have strong feelings about it, I'll patch the comments shortly and add a note in the docs.
from convertdate.
Resolved by 03e77f0.
from convertdate.
Sorry, I missed the notification about your previous comment, and only saw the code update now. That's perfect. Thanks!
from convertdate.
Related Issues (20)
- install fails with pytz 2020.1 HOT 4
- Confusing example in README HOT 1
- hebrew.to_jd() results differ between Python2 and Python3 HOT 3
- Some US Federal holidays are incorrect and/or incomplete. HOT 1
- Incorrect conversion in Bahá'í calendar for Ayyám-i-Há
- Ordinal is wrong for December 31st HOT 2
- Hebrew Calendar should include method to return date where Tishrei is 1 HOT 7
- hebrew.to_jd_gregorianyear(...) cannot unpack non-iterable float object HOT 5
- Julian Date converstion wrong for astronomical years less than -4716 HOT 2
- Islamic Julian Day conversion incorrect for julian day < 1948085.5 HOT 2
- indian_civil.from_gregorian() wrong for gregorian dates before November 25th, 4714 BCE HOT 1
- julian.leap() always truthy for BC years HOT 1
- Human Era support HOT 1
- Add Buddhist Calendar support HOT 1
- Add Babylonian Calendar support HOT 1
- Migrate CI to github workflows
- LGPL-3.0 dependency HOT 1
- Possibly incorrect results for hebrew calendar if years are small HOT 1
- hebrew.monthcalendar returns a 6-day week HOT 1
- Hijri year before year 1 is year -1 not 0.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from convertdate.