setting objects as cookie value about cookie-monster HOT 11 CLOSED

I think it should be added into the lib. If you want, fork and add it or I'll do it in the next few days.

from cookie-monster.

It will be my first time, I mean forking and contributing, but I wanted to start doing for some time.

So, if you have patience if I make a newbie mistake, I will be glad to do it.

I was thinking about using json2 from https://github.com/douglascrockford/JSON-js, how do you think we can hanlde the dependency?

PD: I'm a newbie in github and git in general, but not in javascript ;)

from cookie-monster.

Don't worry about any newbie mistakes, we all make them :)

As far as the external JSON library, I was thinking about leaving it up to the dev to include it. Just do a type check on the value, if it's an object, check if JSON exists (modern browsers have it), if it doesn't, then throw an error. I'd rather the dev determine if they should include the JSON lib rather than just including it by default (saves on size of library). Thoughts?

from cookie-monster.

It's ok for me. I will do it this weekend :)

from cookie-monster.

Ok, I'm ready, now I will try to make a pull request

from cookie-monster.

Ups, I forgot something:

Since the test references the dist versión of the file, I made the chages there. What shoul do now? should I replicate the changes in the lib folder?

I read a little about ender, but node for windows is not very usable yet (not even NPM works, until I think is close)

from cookie-monster.

yeah, you should make your changes to the lib, that will overwrite whatever is in dist when the build script it run. If you want to verify your changes in the test, just point to the lib/monster.js, the other files are just used for building.

I can run the build script and check that in when you make the pull request.

from cookie-monster.

Sorry for so many comments together, but I got npm working on windows (I forgot about that), so I installed ender. Now I'm not sure what command should I use to actually build the code. Obviusly there is a command that take the souce from the lib folder and put it in the dist folder along with AMD integration. What is the command I should use?

from cookie-monster.

to build the dist file, install smoosh (npm install smoosh) and then run make (smoosh make ./build.json).

from cookie-monster.

Yeah, I finally made node with something similar to NPM work in windows. So I finally made the dist and the jslint analysis. There are some errors, but I didn't want to male another commit and pull request. There are little things (a ; missing for example) but all the test are green.

Have had the chance the see the pull request? Since I made it, i discovered how other libraries handle the object serialization for cookies and things like that. Maybe we can revise it, but you first need to see the solution I implemented

from cookie-monster.

looks good. closing this

from cookie-monster.