Giter Club home page Giter Club logo

Comments (5)

AndrewDryga avatar AndrewDryga commented on June 9, 2024

I don't think that we can do anything about it: this is the way docker works. The only fix would be to wrap the docker script into our own and handle edge cases there.

from firezone.

jefferenced avatar jefferenced commented on June 9, 2024

Is there no way to recognize that the auth key or ID is already in use, and fail the install with a readout to that effect?

from firezone.

jefferenced avatar jefferenced commented on June 9, 2024

My concern is — how would someone know they can't re-use the Docker install script?

from firezone.

jamilbk avatar jamilbk commented on June 9, 2024

Hm yeah, docker run -d doesn't bubble the underlying command exit code or output through to the terminal.

@jefferenced There's not a great solution to this particular issue -- ideally we'd nudge users to either copy the command once from the UI, or send them to docs for a different command that can be re-used successfully.

What @AndrewDryga is suggesting could work too, but wrapping in a script obfuscates the actual commands that are being run which is a security turn-off for some folks.

I think probably the best thing to do in the short term is to just make the deploy page more clear that the command only runs successfully once. Users with any familiarity with Docker will know to check the container's exit status / logs.

from firezone.

jefferenced avatar jefferenced commented on June 9, 2024

That makes sense, and maybe something like "one-time use / single use" would be sufficient?

from firezone.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.