Giter Club home page Giter Club logo

Comments (4)

fireice-uk avatar fireice-uk commented on August 22, 2024

You will be surprised at the amount of people that sill have problems with c++11. The *_s functions are unfortunately ignored by the open source community (they are an optional part of C11) as a classic application of "Not Invented Here" syndrome.

In this particular case there are very few practical differences between fopen and fopen_s, and none of those have practical security implications. I won't enable _CRT_SECURE_NO_WARNINGS as this disables the warnings for much more important stuff like strcpy.

from xmr-stak-cpu.

xakepp35 avatar xakepp35 commented on August 22, 2024

Thus, you prohibit to compile it with pure MSVS 2015 (I mean without cmakes, mingws, cygwins, and other non-windows-dev-friendly stuff) Btw, its only change required to make it compile successfully. You just have to add define inside console.cpp file. Its effect will only spread on this file. Because i'd managed to compile thing only by editing sources console.cpp.. Also please consider using c++, in future like instead of pointer to pointer **. Do not use new, do not return pointers, use std::move, its less error prone in terms of memory manipulation, and is very convenient and readible.. just look at this: std::vector< std::thread > thWorkers; a.reserve(10); for( auto i = 0; i <10; i++ ) a.emplace_back( &some_func, someArgPassed );

from xmr-stak-cpu.

xakepp35 avatar xakepp35 commented on August 22, 2024

i want to say, just a good dev advice. either write in c for unix/embedded controllers/maths, or write in c++ for devs, try to not use old deprecated things, learn new ways how things are done nowadays. anyways, you did good job. sorry for my bad english, i tried my best :)

from xmr-stak-cpu.

fireice-uk avatar fireice-uk commented on August 22, 2024

While I wouldn't agree that language x is for that and language y is for that (I prefer to select the language based on the problem at hand, and I don't see either C or C++ as obsolete). If you have the inclination and time to suggest more C++11-like improvements in the code, please do - links to specific lines would be useful.

I finished my uni course in '10 and back then the popular gag was to call it C++never. After that I did way too much python for my liking, so this is my first real C++11 program.

I compile the Windows release using VC++ 14 too and apart from warnings I don't have any problems. Did you enable /WX option?

from xmr-stak-cpu.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.