Comments (1)
The lack of accessor methods is one thing we'll probably want to alleviate going forward, but at the same time, their usage is more of a best effort approach, since even fields which are not public can still be liberally accessed from the module their parent struct is defined in, and from any other children of that module.
While it's true that an incorrectly set size will generate warnings, this will only happen in response to certain guest actions, which can already trigger other similar messages by providing invalid input in quite a number of contexts :-s I think we should try to fix all these similar issues by changing the way we respond to the erroneous conditions within Firecracker, and I'll create an issue regarding this. Closing this one, because I think it's not something that should be considered in isolation.
from firecracker.
Related Issues (20)
- vhost-user-blk device (basic support)
- [Bug] Dev setups for Google Cloud Plattform(GCP) not working properly HOT 2
- Vsock does not work on guest linux kernel version 6.1 HOT 2
- [Bug] parent-cgroup does not work as expected HOT 1
- how to use test_uffd.py HOT 7
- [Feature Request] Would firecracker support linux32, multiboot, multiboot2? HOT 4
- Update comment type for errors with long comments HOT 1
- `deflate_on_oom` doesn't seem to work as expected/documented HOT 5
- [CPU templates] Drop the support of static CPU templates in v2.0.0
- Add test to validate broken links in markdown files
- [Bug] Build fails: unresolved imports rustix::time::Itimerspec, rustix::time::TimerfdClockId HOT 2
- vhost-user-blk device (snapshot support) HOT 1
- Firecracker networking improvements HOT 1
- [vmm] refactor vmm builder code to separate the architecture dependent code in their own modules HOT 1
- Fix running cargo test in parallel for Jailer HOT 2
- [Feature Request] Mac support on M2 and M3 HOT 3
- [Bug] Boot timer seems off HOT 2
- [Bug] Broken S3 Path in Readme for vmlinux. HOT 2
- [Feature Request] Recipe for github actions test runner using firecracker? HOT 2
- Add `clippy::error_impl_error` HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from firecracker.