Giter Club home page Giter Club logo

Comments (10)

aputinski avatar aputinski commented on May 21, 2024

@brancusi I'll try to take a look this week. Thanks for all the context!

from emberfire.

rickharrison avatar rickharrison commented on May 21, 2024

I also had this issue and taking out the belongsTo fixed it for now.

For #2, I think that you can just do item.get('conversions').then(function() {...})

from emberfire.

neverfox avatar neverfox commented on May 21, 2024

I'm having the exact same problem, with the exact same "fix." I'm new to the library as of today (coming from Fireplace), but I imagine this has to be a relatively new bug (assuming that's what it is), given that this is a pretty common scenario that wouldn't have gone unnoticed all the way to a 1.x.x release. It took me all of an hour to run into it. Let me know if I can help try out different scenarios.

from emberfire.

neverfox avatar neverfox commented on May 21, 2024

I should ask, is it more idiomatic to set the belongsTo objects when creating those records (item and unit on the conversion record) and before doing the addObject, like in @brancusi's example? Or to create the record without them, do the addObject, and then all the saves last? Both approaches seem to give identical results.

from emberfire.

neverfox avatar neverfox commented on May 21, 2024

The problem is in ember-data's JSONSerializer here. The only types of relationships that it serializes (1.0.0-beta7) are manyToNone (which is why it works when you drop the belongsTo) and manyToMany. Without the serialized JSON, you won't get the saved references. I don't know if it has always been like this without searching though the commits.

from emberfire.

neverfox avatar neverfox commented on May 21, 2024

According to the notes on the commit for this method, it was the intention of the developers that you would have to override it if you needed to save the ids on the hasMany side. We're not the first to be surprised. It looks like emberfire will have to override this method.

from emberfire.

brancusi avatar brancusi commented on May 21, 2024

@neverfox nice find! Thank you!

from emberfire.

neverfox avatar neverfox commented on May 21, 2024

You're welcome. I was in a bind myself, so I needed it to work. Hopefully, the pull request I submitted is acceptable.

from emberfire.

brancusi avatar brancusi commented on May 21, 2024

I hope so too.

from emberfire.

brancusi avatar brancusi commented on May 21, 2024

Works thank you!

from emberfire.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.